-
Notifications
You must be signed in to change notification settings - Fork 431
chore: bump python version in benchmark dockerfile #13213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 5 ms. The average import time from base is: 238 ± 6 ms. The import time difference between this PR and base is: -0.7 ± 0.2 ms. The difference is not statistically significant (z = -2.87). Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-17 08:43:48 Comparing candidate commit d64b7ce in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 498 metrics, 8 unstable metrics. scenario:iast_aspects-format_map_aspect
scenario:iast_aspects-ospathsplitext_aspect
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor tweaks, otherwise lgtm. thanks, I've been meaning to do this for a awhile.
The change
Bumping the benchmark docker python version to the latest maintenance version of Python3.12.
Motivation:
In a subsequent PR I'm adding benchmarks for a new errortracking feature. The feature is enabled starting from Python3.10.
However starting from Python3.12 we are using a method which potentially adds some overhead. Therefore the errortracking benchmarks need to run on python3.12.
Checklist
Reviewer Checklist