Skip to content

chore: bump python version in benchmark dockerfile #13213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025

Conversation

dubloom
Copy link
Contributor

@dubloom dubloom commented Apr 16, 2025

The change

Bumping the benchmark docker python version to the latest maintenance version of Python3.12.

Motivation:

In a subsequent PR I'm adding benchmarks for a new errortracking feature. The feature is enabled starting from Python3.10.
However starting from Python3.12 we are using a method which potentially adds some overhead. Therefore the errortracking benchmarks need to run on python3.12.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@dubloom dubloom requested a review from a team as a code owner April 16, 2025 11:46
@dubloom dubloom requested a review from erikayasuda April 16, 2025 11:46
@dubloom dubloom added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 16, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

benchmarks/Dockerfile                                                   @DataDog/apm-core-python

Copy link
Contributor

github-actions bot commented Apr 16, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 238 ± 5 ms.

The average import time from base is: 238 ± 6 ms.

The import time difference between this PR and base is: -0.7 ± 0.2 ms.

The difference is not statistically significant (z = -2.87).

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.899 ms (0.80%)
ddtrace.bootstrap.sitecustomize 1.228 ms (0.52%)
ddtrace.bootstrap.preload 1.228 ms (0.52%)
ddtrace.internal.products 1.228 ms (0.52%)
ddtrace.internal.remoteconfig.client 0.599 ms (0.25%)
ddtrace 0.671 ms (0.28%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 16, 2025

Benchmarks

Benchmark execution time: 2025-04-17 08:43:48

Comparing candidate commit d64b7ce in PR branch dubloom/chore-bump-python-benchmark with baseline commit bdca42d in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 498 metrics, 8 unstable metrics.

scenario:iast_aspects-format_map_aspect

  • 🟥 execution_time [+285.615ns; +396.325ns] or [+8.612%; +11.951%]

scenario:iast_aspects-ospathsplitext_aspect

  • 🟥 execution_time [+338.558ns; +542.303ns] or [+7.414%; +11.876%]

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor tweaks, otherwise lgtm. thanks, I've been meaning to do this for a awhile.

@brettlangdon brettlangdon enabled auto-merge (squash) April 16, 2025 16:16
@brettlangdon brettlangdon merged commit 196e922 into main Apr 17, 2025
337 checks passed
@brettlangdon brettlangdon deleted the dubloom/chore-bump-python-benchmark branch April 17, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants