chore: add a job that check that all other jobs are green on PR #13217
+30
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This does not enforce checks on gitlab, for those, the required check on
dd-gitlab/default-pipeline
do the trick (eventually completed by other if needed).Change
Added a job that verify the status of other jobs on the PR:
The next step, once we've validated it works correctly, is to make this job a requirement for merges. Side note, this solution has been implemented successfully on DataDog/dd-trace-js for one year.
I've removed
Bootstrap import analysis
from this check because it 20 PR has been merged with this job failing over the 195 PR on the last 60 days (success rate of 88%). Once this job is considered as healthy (or if we want to enforce it) we can remove it.There are other jobs with a bad success rate, but they are not often included in PR, so TBD. Here are the jobs with a success rate lower than 95% :
Checklist
Reviewer Checklist