chore(profiling): explicitly set or clear NDEBUG for memalloc extension #13218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memalloc C extension has debug assert statements. We want them off
by default in case they guard a costly call we wouldn't normally want to
happen. Depending on how the CPython interpreter running setup.py was
built, we may already get -DNDEBUG via the CFLAGS from sysconfig, which
disables asserts. See the setuptools docs.
But rather than rely on that, make sure that asserts
are explicitly disabled for normal builds and explicitly enabled for
debug builds.
Checklist
Reviewer Checklist