Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Use detox to run Flask tests #812

Closed
wants to merge 4 commits into from

Conversation

brettlangdon
Copy link
Member

detox allows us to execute tox test suites in parallel, and the test run for this PR took about 60 seconds less time to run than previous executions.

@brettlangdon brettlangdon added this to the 0.21.0 milestone Feb 2, 2019
@majorgreys
Copy link
Contributor

majorgreys commented Feb 5, 2019

Looks like detox is unmaintained since tox 3.7 added parallel execution.

What do you think about updating the testrunner image to remove detox and update tox?

https://github.com/DataDog/docker-library/blob/master/dd-trace-py/Dockerfile#L48

@brettlangdon
Copy link
Member Author

Oh wow, this was added since the beginning of this year!

#812

Yeah, I think that is a good idea, 👍 great find.

@brettlangdon brettlangdon changed the base branch from master to 0.21-dev February 5, 2019 20:34
@brettlangdon
Copy link
Member Author

Upgrading to tox 3.7.0 is blocked on: tox-dev/tox#1159

@brettlangdon brettlangdon modified the milestones: 0.21.0, 0.22.0 Feb 13, 2019
@brettlangdon brettlangdon removed this from the 0.22.0 milestone Feb 21, 2019
@Kyle-Verhoog Kyle-Verhoog deleted the brettlangdon/detox.flask branch November 11, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants