Add stack trace collection support #4269

vpellan · 2025-01-09T13:38:33Z

What does this PR do?

This PR adds stack trace collection support using meta_struct

Motivation:

Stack trace collection is required for exploit prevention.

Change log entry

Yes. Fix stack trace not being with RASP SQLi signals

Additional Notes:

How to test the change?

datadog-datadog-prod-us1 · 2025-01-09T13:53:16Z

Datadog Report

Branch report: vpellan/stack-trace-collection
Commit report: a6ab36f
Test service: dd-trace-rb

❌ 9 Failed (0 Known Flaky), 21946 Passed, 1476 Skipped, 5m 27.74s Total Time

❌ Failed Tests (9)

This report shows up to 5 failed tests.

Datadog::AppSec::ActionsHandler.handle calls both generate_stack and block_request when both are present - rspec - Details

Expand for error

 undefined method \`trace' for nil:NilClass
 Did you mean?  trap
 
 Failure/Error: service_entry_operation = context.trace || context.span
 
 NoMethodError:
   undefined method \`trace' for nil:NilClass
   Did you mean?  trap
 ./lib/datadog/appsec/stack_trace.rb:82:in \`add_stack_trace'
 ./lib/datadog/appsec/actions_handler.rb:23:in \`generate_stack'
 ...

Datadog::AppSec::ActionsHandler.handle calls both generate_stack and generate_schema when both are present - rspec - Details

Expand for error

 undefined method \`trace' for nil:NilClass
 Did you mean?  trap
 
 Failure/Error: service_entry_operation = context.trace || context.span
 
 NoMethodError:
   undefined method \`trace' for nil:NilClass
   Did you mean?  trap
 ./lib/datadog/appsec/stack_trace.rb:82:in \`add_stack_trace'
 ./lib/datadog/appsec/actions_handler.rb:23:in \`generate_stack'
 ...

Datadog::AppSec::ActionsHandler.handle calls both generate_stack and redirect_request when both are present - rspec - Details

Expand for error

 undefined method \`trace' for nil:NilClass
 Did you mean?  trap
 
 Failure/Error: service_entry_operation = context.trace || context.span
 
 NoMethodError:
   undefined method \`trace' for nil:NilClass
   Did you mean?  trap
 ./lib/datadog/appsec/stack_trace.rb:82:in \`add_stack_trace'
 ./lib/datadog/appsec/actions_handler.rb:23:in \`generate_stack'
 ...

Datadog::AppSec::ActionsHandler.handle calls generate_stack with action parameters - rspec - Details

Expand for error

 undefined method \`trace' for nil:NilClass
 Did you mean?  trap
 
 Failure/Error: service_entry_operation = context.trace || context.span
 
 NoMethodError:
   undefined method \`trace' for nil:NilClass
   Did you mean?  trap
 ./lib/datadog/appsec/stack_trace.rb:82:in \`add_stack_trace'
 ./lib/datadog/appsec/actions_handler.rb:23:in \`generate_stack'
 ...

Datadog::Tracing::Span#to_hash is expected to eq {:error=>0, :meta=>{}, :metrics=>{}, :name=>"my.span", :parent_id=>0, :resource=>"my.span", :service=>nil, :span_id=>34, :span_links=>[], :trace_id=>12, :type=>nil} - rspec - Details

Expand for error

 expected: {:error=>0, :meta=>{}, :metrics=>{}, :name=>"my.span", :parent_id=>0, :resource=>"my.span", :service=>nil, :span_id=>34, :span_links=>[], :trace_id=>12, :type=>nil}
      got: {:error=>0, :meta=>{}, :meta_struct=>{}, :metrics=>{}, :name=>"my.span", :parent_id=>0, :resource=>"my.span", :service=>nil, :span_id=>34, :span_links=>[], :trace_id=>12, :type=>nil}
 
 (compared using ==)
 
 Diff:
 @@ -1,5 +1,6 @@
  :error => 0,
  :meta => {},
 +:meta_struct => {},
 ...

pr-commenter · 2025-01-09T14:00:47Z

Benchmarks

Benchmark execution time: 2025-03-03 17:52:52

Comparing candidate commit d68d25b in PR branch vpellan/stack-trace-collection with baseline commit 20d026a in branch vpellan/meta-struct.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - gvl benchmark samples

🟥 throughput [-948.107op/s; -940.005op/s] or [-8.158%; -8.088%]

spec/datadog/appsec/stack_trace_spec.rb

y9v · 2025-01-23T09:11:35Z

lib/datadog/appsec/contrib/graphql/reactive/multiplex.rb

@@ -35,7 +35,7 @@ def self.subscribe(engine, context)
                next unless result.match?

                yield result
-                throw(:block, true) unless result.actions.empty?
+                throw(:block, true) if result.actions.include?('block')


why are we changing this everywhere?

datadog-datadog-prod-us1 · 2025-01-23T16:55:47Z

Datadog Report

Branch report: vpellan/stack-trace-collection
Commit report: 365dd2f
Test service: dd-trace-rb

✅ 0 Failed, 22135 Passed, 1476 Skipped, 5m 2.11s Total Time

spec/datadog/appsec/stack_trace_spec.rb

codecov-commenter · 2025-01-24T17:27:49Z

Codecov Report

Attention: Patch coverage is 94.38669% with 27 lines in your changes missing coverage. Please review.

Project coverage is 97.69%. Comparing base (65dd37b) to head (365dd2f).

Files with missing lines	Patch %	Lines
...atadog/appsec/actions_handler/stack_trace/frame.rb	31.57%	13 Missing ⚠️
.../appsec/actions_handler/stack_trace/representor.rb	35.29%	11 Missing ⚠️
lib/datadog/appsec/actions_handler/stack_trace.rb	94.87%	2 Missing ⚠️
spec/support/thread_backtrace_helpers.rb	96.96%	1 Missing ⚠️

Additional details and impacted files

@@                   Coverage Diff                   @@
##           vpellan/meta-struct    #4269      +/-   ##
=======================================================
- Coverage                97.71%   97.69%   -0.02%     
=======================================================
  Files                     1370     1377       +7     
  Lines                    83106    83583     +477     
  Branches                  4227     4254      +27     
=======================================================
+ Hits                     81209    81659     +450     
- Misses                    1897     1924      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

spec/datadog/appsec/stack_trace_spec.rb

spec/datadog/tracing/stack_trace/collector_spec.rb

lib/datadog/tracing/stack_trace/frame.rb

lib/datadog/tracing/stack_trace/representor.rb

spec/datadog/tracing/stack_trace/collector_spec.rb

lib/datadog/tracing/metadata/stack_trace.rb

spec/datadog/tracing/stack_trace/collector_spec.rb

lib/datadog/appsec/actions_handler/stack_trace/representor.rb

spec/datadog/appsec/actions_handler/stack_trace/collector_spec.rb

lib/datadog/appsec/actions_handler/stack_trace/frame.rb

spec/datadog/appsec/actions_handler/stack_trace/collector_spec.rb

- Make metastruct extends Forwardable and forward methods to @Metastruct -add self.empty for when creating an empty metastruct (used in SpanOperation

- Extract Thread:Backtrace:Location to hash convertion - Add Noop class for nil metastruct

Strech · 2025-02-24T13:33:30Z

sig/datadog/appsec/actions_handler.rbs

+
+      private
+
+      def generate_stack_trace: (Integer max_depth, Float top_percent) -> (Hash[Symbol, String | Integer | Array[Hash[Symbol, String | Integer | nil]] | nil ])


Is the return a missing type alias? And with type you can have it recursive

Strech · 2025-02-24T13:45:32Z

sig/datadog/appsec/actions_handler/rasp_stack_trace.rbs

+  module AppSec
+    module ActionsHandler
+      class StackTraceInMetastruct
+        type stack_trace = Hash[Symbol, String | nil | Array[Datadog::AppSec::ActionsHandler::StackTraceCollection::stack_frame]]


Should it be opposite order

Suggested change

type stack_trace = Hash[Symbol, String | nil | Array[Datadog::AppSec::ActionsHandler::StackTraceCollection::stack_frame]]

type stack_trace = Hash[nil, Symbol, String | Array[Datadog::AppSec::ActionsHandler::StackTraceCollection::stack_frame]]

Strech · 2025-02-24T13:50:19Z

spec/support/thread_backtrace_helpers.rb

+    locations = []
+    1000.times do
+      locations << self.locations.first
+    end
+    locations


Will that work?

Suggested change

locations = []

1000.times do

locations << self.locations.first

end

locations

1000.times.map { self.locations.first }

Strech · 2025-02-24T13:56:29Z

spec/datadog/appsec/configuration/settings_spec.rb

+        subject(:set_stack_trace_max_depth_top_percent) do
+          settings.appsec.stack_trace.max_depth_top_percent = stack_trace_max_depth_top_percent
+        end
+
+        context 'when given a value' do
+          let(:stack_trace_max_depth_top_percent) { 50 }
+
+          before { set_stack_trace_max_depth_top_percent }
+
+          it { expect(settings.appsec.stack_trace.max_depth_top_percent).to eq(50) }
+        end
+
+        context 'when given a negative value' do
+          let(:stack_trace_max_depth_top_percent) { -1 }
+
+          before { set_stack_trace_max_depth_top_percent }
+
+          it { expect(settings.appsec.stack_trace.max_depth_top_percent).to eq(0) }
+        end
+
+        context 'when given a value higher than 100' do
+          let(:stack_trace_max_depth_top_percent) { 101 }
+
+          before { set_stack_trace_max_depth_top_percent }
+
+          it { expect(settings.appsec.stack_trace.max_depth_top_percent).to eq(100) }
+        end


I think all the examples could be simplified to examples like

context 'when given a value' do it 'sets max value to 0' do settings.appsec.stack_trace.max_depth_top_percent = -1 expect(settings.appsec.stack_trace.max_depth_top_percent).to eq(0) end end

Strech · 2025-02-24T14:12:16Z

spec/datadog/appsec/actions_handler_spec.rb

+    end
+
+    context 'when stack trace is enabled and context contains only span' do
+      let(:context) { OpenStruct.new(span: span_op) }


Please use verified double i.e (instance_double) here

Strech · 2025-02-24T14:14:11Z

spec/datadog/appsec/actions_handler_spec.rb

+    let(:exploit_category) { Datadog::AppSec::Ext::EXPLOIT_PREVENTION_EVENT_CATEGORY }
+
+    before do
+      Datadog.configure do |c|


FYI if you go this way - you will need to clean the settings afterwards (see other tests where we do that)

Strech · 2025-02-24T14:15:34Z

spec/datadog/appsec/actions_handler_spec.rb

+        ThreadBacktraceHelper.locations_inside_nested_blocks.map.with_index do |location, index|
+          {
+            id: index,
+            text: location.to_s.encode('UTF-8'),
+            file: (location.absolute_path || location.path)&.encode('UTF-8'),
+            line: location.lineno,
+            function: location.label&.encode('UTF-8')
+          }
+        end


TBH i thought that helper suppose to make things easier. I think here it's either missing something or else ...

Strech · 2025-02-24T14:17:12Z

spec/datadog/appsec/actions_handler_spec.rb

@@ -97,4 +101,124 @@
      end
    end
  end
+
+  describe '.generate_stack' do


TBH this test suite look overly complicated and violates certain test practices and it would be easier to go over in 1:1 instead of chatting here.

Strech · 2025-02-28T11:26:01Z

lib/datadog/appsec/actions_handler.rb

+        stack = context.trace.nil? ? span_stack : trace_stack
+        stack.push({ language: 'ruby', id: utf8_stack_id, frames: stack_frames })


Suggested change

stack = context.trace.nil? ? span_stack : trace_stack

stack.push({ language: 'ruby', id: utf8_stack_id, frames: stack_frames })

(context.trace || context.span).push(language: 'ruby', id: stack_id, frames: stack_frames)

This does not work as we are using the push method defined in StackTraceInMetastruct

Strech · 2025-02-28T11:29:43Z

lib/datadog/appsec/actions_handler.rb

+        return if config.max_collect != 0 && span_stack.count + trace_stack.count >= config.max_collect
+
+        # Generate stacktrace
+        utf8_stack_id = action_params['stack_id'].encode('UTF-8') if action_params['stack_id']


This variable will be nil if no params[stack_id] is given, right? I think the whole method will not work without stack_id, hence we always have it or of not - we should do nothing and report a telemetry or generate warning or so.

Because of that that line must be adjusted to

Suggested change

utf8_stack_id = action_params['stack_id'].encode('UTF-8') if action_params['stack_id']

stack_id = action_params['stack_id'].encode('UTF-8')

P.S it doesn't make sense to mention UTF-8 in the variable name because it's not important

Strech · 2025-02-28T11:30:10Z

lib/datadog/appsec/actions_handler.rb

+        span_stack = ActionsHandler::StackTraceInMetastruct.create(context.span&.metastruct)
+        trace_stack = ActionsHandler::StackTraceInMetastruct.create(context.trace&.metastruct)


Suggested change

span_stack = ActionsHandler::StackTraceInMetastruct.create(context.span&.metastruct)

trace_stack = ActionsHandler::StackTraceInMetastruct.create(context.trace&.metastruct)

span_stack = StackTraceInMetastruct.create(context.span&.metastruct)

trace_stack = StackTraceInMetastruct.create(context.trace&.metastruct)

Strech · 2025-02-28T11:32:37Z

lib/datadog/appsec/actions_handler/stack_trace_collection.rb

+        module_function
+
+        def collect(max_depth:, top_percent:)
+          locations = (caller_locations || []).reject { |location| location.to_s.include?('lib/datadog') }


I think it should be converted into mutating to avoid allocation

Suggested change

locations = (caller_locations || []).reject { |location| location.to_s.include?('lib/datadog') }

locations = (caller_locations || [])

locations.reject! { |location| location.to_s.include?('lib/datadog') }

Strech · 2025-02-28T11:34:42Z

lib/datadog/appsec/actions_handler/stack_trace_collection.rb

+          locations.map.with_index do |location, index|
+            {
+              id: index,
+              text: location.to_s.encode('UTF-8'),


This is a second time we convert location into the string, I think it makes sense to do it once at the beginning of the collection

y9v · 2025-03-03T10:43:12Z

lib/datadog/appsec/actions_handler.rb

+          return
+        end
+
+        config = Datadog.configuration.appsec.stack_trace


this should be closer to the guard-clause on line 39

y9v · 2025-03-03T10:44:42Z

lib/datadog/appsec/actions_handler.rb

+        config = Datadog.configuration.appsec.stack_trace
+
+        # Check that the sum of stack_trace count in trace and entry_span does not exceed configuration
+        span_stack = ActionsHandler::StackTraceInMetastruct.create(context.span&.metastruct)


Why are we calling span metastruct a span_stack? Should we rather call it span_metastruct? Same one line below

Because StackTraceInMetastruct is specifically applying changes to '_dd.stack' field of metastruct. We give a metastruct as an input but we cannot do any changes to it other than on the stack traces

y9v · 2025-03-03T10:45:53Z

lib/datadog/appsec/actions_handler.rb

+        # Check that the sum of stack_trace count in trace and entry_span does not exceed configuration
+        span_stack = ActionsHandler::StackTraceInMetastruct.create(context.span&.metastruct)
+        trace_stack = ActionsHandler::StackTraceInMetastruct.create(context.trace&.metastruct)
+        return if config.max_collect != 0 && span_stack.count + trace_stack.count >= config.max_collect


do we want to avoid stack trace collection if the stack is longer than max_collect, or do we want to truncate the stack?

max_collect is the maximum number of stack traces that we want in our trace, not the maximum number of frames in each stack trace (which is defined by max_depth). So if we already have the maximum number of stack traces in metastruct, we want to avoid collection.

y9v · 2025-03-03T10:58:02Z

lib/datadog/appsec/actions_handler/stack_trace_collection.rb

+          top_limit = (max_depth * top_percent / 100.0).round
+          bottom_limit = locations.size - (max_depth - top_limit)
+
+          locations.slice!(top_limit...bottom_limit)


is top_limit lower than bottom_limit?

What are we trying to do here? Get the top n items from the array? Do we really need to calculate both limits, or can we just slice n items from one end?

For example, if max_depth is 32 and top_percent is 75%, and we have more than 32 stack frames, we want to keep the 24th first stack traces, the 8th last, and drop everything in the middle. So what this method do is calculate the limits of the frames that we should drop, so we can just do a slice on the locations with that range

according to RFC, we have to take 2 slices - one from the top of the stack trace, and one from the bottom:

In the original RFC, some restrictions were placed on the layout of stack traces, namely: Stack traces must contain a maximum of 32 frames. When a stack trace is truncated, 24 frames should be from the bottom of the stack and 8 from the top. The number of top and bottom frames on truncated stack traces can be considered a flexible requirement and it’s up to the library implementor to decide the most useful number of frames from each side of the stack for their language. In addition, since the user can configure the maximum number of frames through the use of DD_APPSEC_MAX_STACK_TRACE_DEPTH, the number of top and bottom frames for a truncated stack trace of arbitrary size must be computed dynamically based on the configuration value, with the simplest approach being a proportional one. Similarly, the default maximum number of frames might not be particularly useful in languages with notoriously deep stacks, for that reason, the requirement must be updated to ensure that each library can provide meaningful stack traces. Given the above, the requirements can be amended as follows: Stack traces must be limited to a maximum of 32 frames, or a more suitable higher value for the given language. When a stack trace is truncated, libraries must collect some frames from both the top and bottom of the stack. As a recommendation, libraries may collect 75% of frames from the bottom of the stack and 25% from the top.

I think this is not what we are doing here?

…ck_trace_collection - Fix specs

y9v · 2025-03-05T18:01:25Z

lib/datadog/appsec/actions_handler/stack_trace_collection.rb

+          top_limit = (max_depth * top_percent / 100.0).round
+          bottom_limit = locations.size - (max_depth - top_limit)
+
+          locations.slice!(top_limit...bottom_limit)


according to RFC, we have to take 2 slices - one from the top of the stack trace, and one from the bottom:

In the original RFC, some restrictions were placed on the layout of stack traces, namely: Stack traces must contain a maximum of 32 frames. When a stack trace is truncated, 24 frames should be from the bottom of the stack and 8 from the top. The number of top and bottom frames on truncated stack traces can be considered a flexible requirement and it’s up to the library implementor to decide the most useful number of frames from each side of the stack for their language. In addition, since the user can configure the maximum number of frames through the use of DD_APPSEC_MAX_STACK_TRACE_DEPTH, the number of top and bottom frames for a truncated stack trace of arbitrary size must be computed dynamically based on the configuration value, with the simplest approach being a proportional one. Similarly, the default maximum number of frames might not be particularly useful in languages with notoriously deep stacks, for that reason, the requirement must be updated to ensure that each library can provide meaningful stack traces. Given the above, the requirements can be amended as follows: Stack traces must be limited to a maximum of 32 frames, or a more suitable higher value for the given language. When a stack trace is truncated, libraries must collect some frames from both the top and bottom of the stack. As a recommendation, libraries may collect 75% of frames from the bottom of the stack and 25% from the top.

I think this is not what we are doing here?

y9v · 2025-03-05T18:11:02Z

lib/datadog/appsec/actions_handler/stack_trace_collection.rb

+              text: text,
+              file: location.absolute_path || location.path,
+              line: location.lineno,
+              function: location.label


RFC specifies separate class_name and function fields, and #label is containing both class name and function name. We have to parse it

vpellan · 2025-03-06T13:37:57Z

according to RFC, we have to take 2 slices - one from the top of the stack trace, and one from the bottom. I think this is not what we are doing here?

The slice! method will remove the part in the middle and locations will then contains the top part and the bottom part only.

y9v · 2025-03-06T13:41:32Z

according to RFC, we have to take 2 slices - one from the top of the stack trace, and one from the bottom. I think this is not what we are doing here?

The slice! method will remove the part in the middle and locations will then contains the top part and the bottom part only.

sorry, my bad, you are right

github-actions bot added integrations Involves tracing integrations appsec Application Security monitoring product tracing labels Jan 9, 2025

vpellan force-pushed the vpellan/stack-trace-collection branch from f79044e to 77e9969 Compare January 14, 2025 15:40

datadog-datadog-prod-us1 bot reviewed Jan 21, 2025

View reviewed changes

spec/datadog/appsec/stack_trace_spec.rb Outdated Show resolved Hide resolved

datadog-datadog-prod-us1 bot reviewed Jan 21, 2025

View reviewed changes

spec/datadog/appsec/stack_trace_spec.rb Outdated Show resolved Hide resolved

vpellan force-pushed the vpellan/stack-trace-collection branch from 5d75fc3 to 255e242 Compare January 21, 2025 16:17

y9v reviewed Jan 23, 2025

View reviewed changes

datadog-datadog-prod-us1 bot reviewed Jan 24, 2025

View reviewed changes

spec/datadog/appsec/stack_trace_spec.rb Outdated Show resolved Hide resolved

spec/datadog/appsec/stack_trace_spec.rb Outdated Show resolved Hide resolved

datadog-datadog-prod-us1 bot reviewed Jan 27, 2025

View reviewed changes

spec/datadog/appsec/stack_trace_spec.rb Outdated Show resolved Hide resolved

datadog-datadog-prod-us1 bot reviewed Jan 29, 2025

View reviewed changes

spec/datadog/tracing/stack_trace/collector_spec.rb Outdated Show resolved Hide resolved

datadog-datadog-prod-us1 bot reviewed Jan 30, 2025

View reviewed changes

lib/datadog/tracing/metadata/stack_trace.rb Outdated Show resolved Hide resolved

spec/datadog/tracing/stack_trace/collector_spec.rb Outdated Show resolved Hide resolved

vpellan force-pushed the vpellan/stack-trace-collection branch from 5dfecd6 to 7aa25ec Compare January 31, 2025 12:10

vpellan changed the base branch from master to vpellan/meta-struct January 31, 2025 12:11

vpellan force-pushed the vpellan/meta-struct branch 2 times, most recently from b3dc5c2 to 0836e11 Compare January 31, 2025 12:48

vpellan changed the title ~~Add meta_struct and stack trace collection~~ Add stack trace collection support Jan 31, 2025

vpellan force-pushed the vpellan/meta-struct branch 4 times, most recently from a771a6d to 65dd37b Compare February 6, 2025 12:31

vpellan force-pushed the vpellan/stack-trace-collection branch from 7aa25ec to c49806e Compare February 7, 2025 16:43

datadog-datadog-prod-us1 bot reviewed Feb 7, 2025

View reviewed changes

vpellan force-pushed the vpellan/stack-trace-collection branch from c49806e to 9f10909 Compare February 7, 2025 16:46

datadog-datadog-prod-us1 bot reviewed Feb 7, 2025

View reviewed changes

spec/datadog/appsec/actions_handler/stack_trace/collector_spec.rb Outdated Show resolved Hide resolved

Add .dig to metastruct

630c10d

vpellan force-pushed the vpellan/meta-struct branch from 65dd37b to 630c10d Compare February 19, 2025 14:50

vpellan requested a review from a team as a code owner February 19, 2025 14:50

vpellan force-pushed the vpellan/stack-trace-collection branch from 365dd2f to 8bae22c Compare February 19, 2025 15:28

vpellan requested review from y9v and Strech February 20, 2025 10:30

Remove metastruct private method

a3ce0bb

vpellan force-pushed the vpellan/stack-trace-collection branch from 8bae22c to 8aa9b65 Compare February 20, 2025 13:39

vpellan added 3 commits February 21, 2025 15:17

- Move merger as a constant

20d026a

- Make metastruct extends Forwardable and forward methods to @Metastruct -add self.empty for when creating an empty metastruct (used in SpanOperation

Add stack trace collection to meta_struct and actions_handler

110e1eb

-Change naming form RaspStackTrace to StackTraceInMetastruct

094cc5e

- Extract Thread:Backtrace:Location to hash convertion - Add Noop class for nil metastruct

vpellan force-pushed the vpellan/stack-trace-collection branch from 8aa9b65 to 094cc5e Compare February 21, 2025 14:32

Strech requested changes Feb 24, 2025

View reviewed changes

vpellan added 3 commits February 27, 2025 16:22

Changed collect args to keywords

1cbf501

remove intermediary variable

7cfb7b8

Reorganize specs

c60706a

Strech reviewed Feb 28, 2025

View reviewed changes

y9v requested changes Mar 3, 2025

View reviewed changes

This was referenced Mar 3, 2025

Add AppSec RASP SQLI remote capability #4445

Open

Add AppSec server-side request forgery remote capability #4446

Open

- Small adjustments to improve performance in actions_handler and sta…

d68d25b

…ck_trace_collection - Fix specs

y9v requested changes Mar 5, 2025

View reviewed changes

y9v force-pushed the vpellan/meta-struct branch 2 times, most recently from 1fe22fc to 2e8289c Compare March 6, 2025 12:34

y9v force-pushed the vpellan/meta-struct branch from d580c5e to a70a07e Compare March 10, 2025 09:11

Base automatically changed from vpellan/meta-struct to master March 10, 2025 10:15

y9v closed this Mar 10, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add stack trace collection support #4269

Add stack trace collection support #4269

vpellan commented Jan 9, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Jan 9, 2025 •

edited

Loading

pr-commenter bot commented Jan 9, 2025 •

edited

Loading

y9v Jan 23, 2025

datadog-datadog-prod-us1 bot commented Jan 23, 2025 •

edited

Loading

codecov-commenter commented Jan 24, 2025 •

edited

Loading

Strech Feb 24, 2025

Strech Feb 24, 2025

Strech Feb 24, 2025

Strech Feb 24, 2025

Strech Feb 24, 2025

Strech Feb 24, 2025

Strech Feb 24, 2025

Strech Feb 24, 2025

Strech Feb 28, 2025

vpellan Mar 3, 2025

Strech Feb 28, 2025

Strech Feb 28, 2025

Strech Feb 28, 2025

Strech Feb 28, 2025

y9v Mar 3, 2025

y9v Mar 3, 2025

vpellan Mar 3, 2025

y9v Mar 3, 2025

vpellan Mar 3, 2025

y9v Mar 3, 2025

vpellan Mar 3, 2025 •

edited

Loading

y9v Mar 5, 2025

y9v Mar 5, 2025

y9v Mar 5, 2025

vpellan commented Mar 6, 2025

y9v commented Mar 6, 2025


		private

		def generate_stack_trace: (Integer max_depth, Float top_percent) -> (Hash[Symbol, String \| Integer \| Array[Hash[Symbol, String \| Integer \| nil]] \| nil ])

	type stack_trace = Hash[Symbol, String \| nil \| Array[Datadog::AppSec::ActionsHandler::StackTraceCollection::stack_frame]]
	type stack_trace = Hash[nil, Symbol, String \| Array[Datadog::AppSec::ActionsHandler::StackTraceCollection::stack_frame]]

		stack = context.trace.nil? ? span_stack : trace_stack
		stack.push({ language: 'ruby', id: utf8_stack_id, frames: stack_frames })

	stack = context.trace.nil? ? span_stack : trace_stack
	stack.push({ language: 'ruby', id: utf8_stack_id, frames: stack_frames })
	(context.trace \|\| context.span).push(language: 'ruby', id: stack_id, frames: stack_frames)

	utf8_stack_id = action_params['stack_id'].encode('UTF-8') if action_params['stack_id']
	stack_id = action_params['stack_id'].encode('UTF-8')

		span_stack = ActionsHandler::StackTraceInMetastruct.create(context.span&.metastruct)
		trace_stack = ActionsHandler::StackTraceInMetastruct.create(context.trace&.metastruct)

	locations = (caller_locations \|\| []).reject { \|location\| location.to_s.include?('lib/datadog') }
	locations = (caller_locations \|\| [])
	locations.reject! { \|location\| location.to_s.include?('lib/datadog') }

Add stack trace collection support #4269

Add stack trace collection support #4269

Conversation

vpellan commented Jan 9, 2025 • edited Loading

datadog-datadog-prod-us1 bot commented Jan 9, 2025 • edited Loading

Datadog Report

❌ Failed Tests (9)

pr-commenter bot commented Jan 9, 2025 • edited Loading

Benchmarks

scenario:profiler - gvl benchmark samples

Choose a reason for hiding this comment

datadog-datadog-prod-us1 bot commented Jan 23, 2025 • edited Loading

Datadog Report

codecov-commenter commented Jan 24, 2025 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vpellan Mar 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vpellan commented Mar 6, 2025

y9v commented Mar 6, 2025

vpellan commented Jan 9, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Jan 9, 2025 •

edited

Loading

pr-commenter bot commented Jan 9, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Jan 23, 2025 •

edited

Loading

codecov-commenter commented Jan 24, 2025 •

edited

Loading

vpellan Mar 3, 2025 •

edited

Loading