-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve SSI #4366
base: master
Are you sure you want to change the base?
Improve SSI #4366
Conversation
👋 Hey @lloeki, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md (possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None. (possible answers No/Nope/None) Visited at: 2025-02-12 10:56:12 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 20606 Passed, 1375 Skipped, 3m 19.08s Total Time |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4366 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 1365 1365
Lines 83337 83337
Branches 4219 4219
=======================================
Hits 81447 81447
Misses 1890 1890 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e7b84d1
to
4667b63
Compare
Ruby 2.6 showed up a lot in telemetry.
What does this PR do?
General improvements to the current SSI injector bootstrap implementation
Motivation:
Some things are not quite covered.
Change log entry
Additional Notes:
How to test the change?
It's a bit hard right now, either we have small granularity CI but a lot of environmental invasion (rspec) or we have isolation but coarse granularity (vaccine). Working on it.
#4366