Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SSI #4366

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Improve SSI #4366

wants to merge 7 commits into from

Conversation

lloeki
Copy link
Member

@lloeki lloeki commented Feb 11, 2025

What does this PR do?

General improvements to the current SSI injector bootstrap implementation

Motivation:

Some things are not quite covered.

Change log entry

Additional Notes:

How to test the change?

It's a bit hard right now, either we have small granularity CI but a lot of environmental invasion (rspec) or we have isolation but coarse granularity (vaccine). Working on it.

#4366

Copy link

github-actions bot commented Feb 11, 2025

👋 Hey @lloeki, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-02-12 10:56:12 UTC

@github-actions github-actions bot added the single-step Single Step APM Instrumentation label Feb 11, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Feb 11, 2025

Datadog Report

Branch report: lloeki/ssi
Commit report: 16d209e
Test service: dd-trace-rb

✅ 0 Failed, 20606 Passed, 1375 Skipped, 3m 19.08s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (0e4b45c) to head (16d209e).
Report is 151 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4366   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files        1365     1365           
  Lines       83337    83337           
  Branches     4219     4219           
=======================================
  Hits        81447    81447           
  Misses       1890     1890           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks

Benchmark execution time: 2025-02-21 12:57:12

Comparing candidate commit 16d209e in PR branch lloeki/ssi with baseline commit 0e4b45c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
single-step Single Step APM Instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants