DEBUG-3568 Remove transport API instance/spec branching #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for updating Change log entry section 👏 Visited at: 2025-03-17 13:26:38 UTC |
Datadog ReportBranch report: ✅ 0 Failed, 20614 Passed, 1458 Skipped, 3m 8.47s Total Time |
p-datadog
force-pushed
the
transport-dry-3
branch
from
e028f90 to
5c5916c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4480 +/- ##
==========================================
- Coverage 97.76% 97.76% -0.01%
==========================================
Files 1390 1390
Lines 84748 84741 -7
Branches 4281 4281
==========================================
- Hits 82856 82843 -13
- Misses 1892 1898 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
p-datadog
force-pushed
the
transport-dry-3
branch
from
5c5916c to
71618a4
Compare
p-datadog
changed the title
p-datadog
force-pushed
the
transport-dry-3
branch
from
71618a4 to
8cab7e1
Compare
y9v
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR moves toward having transport API Instance and Spec classes being API-specific. Currently, these classes are one for a component (e.g. remote/tracing/DI) but these classes combine functionality from multiple APIs and then downstream code has API-specific classes again that reference these "combined" Instance and Spec classes.
The idea is to have all of the transport-related classes be scoped to one API.
This PR removes the branching of one API -> multiple APIs -> one API again but leaves tracing instance & spec classes unchanged which makes them defined in a slightly different way from remote & DI counterparts.
Motivation:
Making transport code more readable.
Change log entry
None
Additional Notes:
How to test the change?
Existing unit tests