Update lograge/patcher.rb so that the correct logger is checked #4496
+33
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR I make sure that when the Lograge logger is present, it is checked instead of the Rails logger for showing a warning about tagged logging.
Motivation:
When the lograge
keep_original_rails_log
option is used, the lograge logger cannot be found in::Lograge::LogSubscribers::ActionController
, as the existing actioncontroller log subscriber is never removed. Therefore the warning inlograge/patcher.rb
is shown even when lograge does use a plain logger.Change log entry
Hide the warning about tagged logging when Lograge uses a plain logger and
keep_original_rails_log
is enabled.Additional Notes:
How to test the change?
The change should be covered by the tests. If you want to test it manually, enable the Lograge
keep_original_rails_log
config option, keep the default Rails logger but use a plain logger in the lograge config. Now there should no longer be an error about tagged logging.