Skip to content

feat(propagation): baggage support and automatic propagation #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 19, 2025

Conversation

ZStriker19
Copy link
Contributor

What does this PR do?
Following the spec here: https://www.w3.org/TR/baggage/ we implement baggage for the Ruby tracer. The otel drop in support will be added in a future PR.
Motivation:

Change log entry

  • Tracing: Added support for W3C Baggage extraction and injection by default.
  • Tracing: Adds api method to access and modify baggage object.

Additional Notes:

How to test the change?
Tests were added in the repo and it passes the weblog system-tests. It will not pass the parametric system-tests because of the difficulty of managing the context in server.rb, not due an issue of implementation of the actual feature.

@ZStriker19
Copy link
Contributor Author

Following up from #4371 which was merged with issues

@ZStriker19 ZStriker19 force-pushed the zachg/baggage_support branch from fdb6d56 to 8362c1e Compare March 17, 2025 18:19
@pr-commenter
Copy link

pr-commenter bot commented Mar 17, 2025

Benchmarks

Benchmark execution time: 2025-03-19 14:15:03

Comparing candidate commit e827430 in PR branch zachg/baggage_support with baseline commit 5544d29 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 17, 2025

Datadog Report

Branch report: zachg/baggage_support
Commit report: e827430
Test service: dd-trace-rb

✅ 0 Failed, 20723 Passed, 1371 Skipped, 3m 19.55s Total Time

@ZStriker19 ZStriker19 closed this Mar 17, 2025
@ZStriker19 ZStriker19 force-pushed the zachg/baggage_support branch from 4f76aad to 8efab4f Compare March 17, 2025 18:56
@ZStriker19 ZStriker19 reopened this Mar 17, 2025
@github-actions github-actions bot added the integrations Involves tracing integrations label Mar 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 99.24242% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.69%. Comparing base (4306938) to head (e827430).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
lib/datadog/tracing/distributed/baggage.rb 97.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4505      +/-   ##
==========================================
- Coverage   97.70%   97.69%   -0.01%     
==========================================
  Files        1381     1383       +2     
  Lines       84017    84260     +243     
  Branches     4253     4278      +25     
==========================================
+ Hits        82085    82321     +236     
- Misses       1932     1939       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ZStriker19 ZStriker19 marked this pull request as ready for review March 17, 2025 20:03
@ZStriker19 ZStriker19 requested review from a team as code owners March 17, 2025 20:03
@ZStriker19 ZStriker19 merged commit d6b3e6d into master Mar 19, 2025
461 checks passed
@ZStriker19 ZStriker19 deleted the zachg/baggage_support branch March 19, 2025 14:16
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 19, 2025
@vpellan vpellan mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants