-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix hygiene #4511
Nix hygiene #4511
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4511 +/- ##
==========================================
- Coverage 97.76% 97.75% -0.01%
==========================================
Files 1392 1392
Lines 84890 84890
Branches 4277 4277
==========================================
- Hits 82995 82988 -7
- Misses 1895 1902 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 20782 Passed, 1370 Skipped, 3m 16.85s Total Time |
BenchmarksBenchmark execution time: 2025-03-26 15:19:04 Comparing candidate commit 18c76ce in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:tracing - Propagation - Datadog
|
I am not seeing the nix failures that are currently attached to this PR in other PRs, therefore I assume they are somehow related to the changes made by this PR and I think those failures need to be investigated and repaired before merging. |
bb7976b
to
e047cd7
Compare
The full error is:
Interestingly enough it's not that it doesn't see the local repo's This does return the spec:
|
So I got down the rabbit hole: In the failing case (this PR):
In the success case (
This traces us to this commit: Whose title is:
The PR being rubygems/rubygems#8104 Well extensions are missing because they have bot been built. Most notably on darwin some of them cannot:
Ergo Therefore the test as it is written fails "legitimately": it essentially means that the But it is quite arguable that what's written there is what should be done. Indeed the only point of this access to the spec is to get to In any case, the issue is unrelated to Nix. |
`rubygems` started enforcing extensions to be built via `Gem::Specification#ignored?`. This causes the `datadog` spec lookup via `Gem::Specification.find_by_name` to fail. Since in this case we don't care for the extension, replace by `Gem.loaded_specs`, which is what matters there. Note that `Gem::SpecificationRecord.find_all_by_name` is not subject to the `ignored?` check, only `Specification.find_by_name` is (via `Gem::Dependency#to_spec`), so we could use that; unfortunately it is fairly recent and unavailable for older rubygems versions. See: - rubygems/rubygems@c80998a - rubygems/rubygems#8104 - #4511 (comment)
`rubygems` started enforcing extensions to be built via `Gem::Specification#ignored?`. This causes the `datadog` spec lookup via `Gem::Specification.find_by_name` to fail. Since in this case we don't care for the extension, replace by `Gem.loaded_specs`, which is what matters there. Note that `Gem::SpecificationRecord.find_all_by_name` is not subject to the `ignored?` check, only `Specification.find_by_name` is (via `Gem::Dependency#to_spec`), so we could use that; unfortunately it is fairly recent and unavailable for older rubygems versions. See: - rubygems/rubygems@c80998a - rubygems/rubygems#8104 - #4511 (comment)
dfcdfc9
to
31b29ba
Compare
`rubygems` started enforcing extensions to be built via `Gem::Specification#ignored?`. This causes the `datadog` spec lookup via `Gem::Specification.find_by_name` to fail. Since in this case we don't care for the extension, replace by `Gem.loaded_specs`, which is what matters there. Note that `Gem::SpecificationRecord.find_all_by_name` is not subject to the `ignored?` check, only `Specification.find_by_name` is (via `Gem::Dependency#to_spec`), so we could use that; unfortunately it is fairly recent and unavailable for older rubygems versions. See: - rubygems/rubygems@c80998a - rubygems/rubygems#8104 - #4511 (comment)
31b29ba
to
18c76ce
Compare
What does this PR do?
pkgs
reference instead of the desired pinnedllvm
Motivation:
Up to date nix shell
Change log entry
Nope
Additional Notes:
How to test the change?