Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDCD-887: updating DORA setup documentation to include GitLab, which is in closed preview #27931

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

henrywalsh
Copy link
Contributor

@henrywalsh henrywalsh commented Mar 3, 2025

What does this PR do? What is the motivation?

We are enabling GitLab integration in DORA metrics. However, Datadog's gitlab integration is in preview so we need our docs to reflect that. When the GitLab integration is no longer in preview (currently it is anticipated to be GA in Q2) these docs will be updated.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Preview links (active after the build_preview check completes)

Modified Files

@henrywalsh henrywalsh marked this pull request as ready for review March 4, 2025 08:47
@henrywalsh henrywalsh requested review from a team as code owners March 4, 2025 08:47
@henrywalsh henrywalsh requested a review from andrea-mosk March 4, 2025 08:47
Copy link
Contributor

@andrea-mosk andrea-mosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions!

{{% tab "GitLab" %}}
<div class="alert alert-warning">Datadog's GitLab integration is in closed preview.</div>

To request access to Datadog's GitLab integration for your organization, reach out to [Datadog Support][1].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest putting this in the div above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maycmlee Checking this page after the build completed, and it looks like the link no longer works when this line is in the div. Is there a way to work around that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @henrywalsh ! Links in the div need to be in HTML. I pushed up a commit to fix that.

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to /merge when you want to publish it.

Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your newest edits look great, Henry! I have one content suggestion that you're free to take or leave, and another capitalization suggestion that I noticed while I was looking at your new content. Regardless of what you do with either suggestion, my approval should hold, and you can add it to the merge queue anytime. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants