Update SFN Trace Merging #28180
Draft
Update SFN Trace Merging #28180
+159
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
kimi-p
reviewed
Mar 20, 2025
| @@ -8,51 +8,160 @@ further_reading: | |||
|
|
|||
| This page describes how to merge your AWS Step Functions traces with related AWS Lambda traces or nested Step Functions traces. These instructions assume that you have already instrumented these [AWS Step Functions][1] and [Lambda functions][2] to send traces to Datadog. | |||
|
|
|||
| <div class="alert alert-info">Datadog recommends using <code>JSONata</code> to define your Step Function payloads for the most complete end-to-end tracing experience. If you are using <code>JSONPath</code> to define your Step Function payloads, see the below sections for supported configurations</a>.</div> | |||
| <div class="alert alert-info">Datadog recommends using <code>JSONata</code> to define your Step Function definitions for the most complete end-to-end tracing experience. This approach will ensure that any context upstream to the Step Function will be preserved and passed down. If you are using <code>JSONPath</code> to define your Step Function definitions, see the below sections for supported configurations</a>.</div> | |||
There was a problem hiding this comment.
If you are using JSONPath to define your Step Function definitions, see the below sections for supported configurations.
Not because of the PR, but I think what section is about JSONPath is not clear to me. Looks like only the last two sections are about JSONata. We could either create two tabs (one for JSONPath; one for JSONata) or simply state see the last two sections.
- Merge with downstream Lambda traces (JSONPath)
- Merge with nested Step Functions traces (JSONPath)
There was a problem hiding this comment.
Since we have tabs in the JSONPath section, I couldn't get the nested tabs to work
I can come back and figure out how to do it but for now I just said "see bottom of the page"
There was a problem hiding this comment.
Or last two sections to be more specific. Either way sgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes