Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollback detection docs | SDCD-952 #28215

Merged
merged 5 commits into from
Mar 24, 2025

Conversation

Aaron-9900
Copy link
Member

@Aaron-9900 Aaron-9900 commented Mar 18, 2025

What does this PR do? What is the motivation?

Adds documentation for the new CD Visibility rollbacks feature

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@Aaron-9900 Aaron-9900 requested review from a team as code owners March 18, 2025 13:14
@Aaron-9900 Aaron-9900 requested a review from TovRudyy March 18, 2025 13:14
@Aaron-9900 Aaron-9900 marked this pull request as draft March 18, 2025 13:14
@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels Mar 18, 2025
Copy link
Contributor

Signed-off-by: Aaron Hoffman <[email protected]>
@Aaron-9900 Aaron-9900 force-pushed the aaron.hoffman/SDCD-952_write-rollback-cd-docs branch from ce39b6a to 2a83a13 Compare March 18, 2025 13:38
@Aaron-9900 Aaron-9900 requested review from andrea-mosk and removed request for TovRudyy March 18, 2025 13:48
@Aaron-9900 Aaron-9900 marked this pull request as ready for review March 18, 2025 13:48
@joepeeples joepeeples self-assigned this Mar 18, 2025
@joepeeples joepeeples self-requested a review March 18, 2025 14:00
@joepeeples joepeeples added the editorial review Waiting on a more in-depth review label Mar 18, 2025
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a few line-edit suggestions. Also, in the screenshots, consider cropping out the left nav sidebar in case that part of the UI changes in the future.

@Aaron-9900
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 24, 2025

View all feedbacks in Devflow UI.
2025-03-24 08:47:11 UTC ℹ️ Start processing command /merge


2025-03-24 08:47:17 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-03-24 08:48:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 9m (p90).


2025-03-24 08:56:58 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit b3c038e into master Mar 24, 2025
16 of 20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aaron.hoffman/SDCD-952_write-rollback-cd-docs branch March 24, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants