-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM Auto-instrumentation updates #28233
base: master
Are you sure you want to change the base?
Conversation
@@ -1,6 +1,58 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is a customer supposed to navigate to this section? Given the path it looks to me like it is supposed to be visible when clicking here
auto-instrumentation-updates/real_user_monitoring/browser/setup
But instead on that left menu, or the breadcrumbs, the content for "real_user_monitoring/browser/setup/client" is shown instead. It might just be me misunderstanding how navigation is supposed to happen, though (If so, can you link to the page here? 🙇 ).
|
||
Keep in mind the following limitations when using this setup: | ||
|
||
- This instrumentation method **does not support [advanced RUM configurations][1]**, except for `allowedTracingUrls` and `excludedActivityUrls`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Comment applies to all servers)
The phrasing we had before (This instrumentation method does not support any advanced RUM configurations. However, allowedTracingUrls and excludedActivityUrls are supported
) didn't imply allowedTracingUrls and excludedActivityUrls are advanced RUM configurations, while now I think it does. They are not mentioned in the advanced RUM configurations page, so that might be confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am no native english speaker but the "however" in the original wording seems to indicate allowedTracingUrls
and excludedActivityUrls
are advanced configuration. I am also non RUM expert, IIRC advanced configuration are configurations supporting arrays and functions, these two are compatible with arrays and functions. Summoning @allspain for clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving Damien's comment into the PR comments: this is not the appropriate logo for IBM HTTP Server
Co-authored-by: pablomartinezbernardo <[email protected]>
What does this PR do? What is the motivation?
Per discussion with @sarjyusuf, this primarily contains the following updates:
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes
To be reviewed by RUM Eng before merging.