Improve commit metadata reference in Argo CD docs #28250
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
jhgilbert
reviewed
Mar 19, 2025
| <ul> | ||
| <li>You are already syncing your repository information to Datadog (see <a href="/continuous_delivery/features/code_changes_detection#synchronize-repository-metadata-to-datadog">synchronize your repository metadata to Datadog</a>).</li> | ||
| <li>Your Argo CD application source does not have a defined commit SHA (for example, if you are using Helm repositories).</li> | ||
| </ul> |
There was a problem hiding this comment.
Alerts aren't really meant to contain lists or other detailed content, so the result looks awkward (see screenshot). Would it make sense to just use regular copy under a dedicated header or something like that? Let me know if you want help with it!
There was a problem hiding this comment.
Good spot, thanks! I have removed the alert format :)
jhgilbert
approved these changes
Mar 19, 2025
drodriguezhdez
approved these changes
Mar 20, 2025
…ention-in-argocd-docs
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
andrea.moscatelli/adjust-commit-metadata-mention-in-argocd-docs
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Improve commit metadata reference in Argo CD docs
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes