-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IAST Security Controls - Node.js #28258
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
`INPUT_VALIDATOR:COMMAND_INJECTION:bar/foo/custom_input_validator.js:validators.validate` | ||
|
||
#### Security control method from a transitive dependency | ||
As long as the `node_modules` folder is present in the file path of a security control definition, all files whose file path ends with that path are evaluated as such. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain this line in more words? I'm having trouble understanding it. In particular, what do you mean by "ends with that path?"
Is the sentence telling people how to make sure all of their security controls, including ones from transitive dependencies, are evaluated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I understand this sentence is explaining our internal implementation of the security control path finding algorithm. Instead we should probably explain the implications of this implementation:
As long as the `node_modules` folder is present in the file path of a security control definition, all files whose file path ends with that path are evaluated as such. | |
Because of npm's flat dependency structure, it is not possible to differentiate between a direct dependency and a transitive dependency. This means if one dependency is [defined in a security control, not sure how to word that], all instances of that dependency (direct or transitive), will be affected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @simon-id. I've adjusted your suggestion and committed the changes.
@urseberry could you check it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What does this PR do? What is the motivation?
Updates IAST security controls documentation with Node.js information:
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes