-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump protobuf
and ring
as suggested by dependabot
#938
Conversation
Cargo.lock
Outdated
"windows-sys 0.59.0", | ||
"windows-sys 0.48.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why the dependency is actually getting downgraded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch... Cargo seems to be non-deterministic here, or at least buggy -- running cargo update -p winapi-util
will make it flip back and forth on versions here. Fixed manually in 72bef35 .
BenchmarksComparisonBenchmark execution time: 2025-03-21 09:36:18 Comparing candidate commit 405a237 in PR branch Found 9 performance improvements and 2 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/ 3782-8224-6310-005
scenario:credit_card/is_card_number/ 378282246310005
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/x371413321323331
scenario:sql/obfuscate_sql_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #938 +/- ##
==========================================
- Coverage 72.96% 72.84% -0.13%
==========================================
Files 334 334
Lines 50915 50923 +8
==========================================
- Hits 37149 37093 -56
- Misses 13766 13830 +64
🚀 New features to boost your workflow:
|
Hmm... the "FFI alpine-build via docker bake" is broken and I believe it's because of rust-lang/cc-rs#1407 . That should be fixed in version 1.2.17 of the |
@ivoanjo , it's a known issue for now, I suggest something like this: cargo update cc --precise 1.1.31 This is the exact command I ran a few months ago. I see 1.1.37 is out, I have not verified that one, but you could try it. |
protobuf
and ring
as suggested by dependabotprotobuf
and ring
as suggested by dependabot
Unfortunately that doesn't work, the latest ring wants a newer cc:
:( |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
i686-alpine-linux-musl
i686-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
Let's see if these fixes the issues with building on alpine...
The upgrade to cc 1.2.17 works! 🎉 CI is now green :) |
What does this PR do?
Dependabot was suggesting bumping these two, and they seem to work fine.
Motivation
Keep our dependencies up-to-date.
Additional Notes
N/A
How to test the change?
Our existing test coverage should be enough to cover these.