Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid struct<Generic = ()> in cbindgen-read definitions #951

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Avoid struct<Generic = ()> in cbindgen-read definitions #951

merged 2 commits into from
Mar 20, 2025

Conversation

bwoebi
Copy link
Contributor

@bwoebi bwoebi commented Mar 20, 2025

Works around mozilla/cbindgen#993 in cbindgen 0.27+

@bwoebi bwoebi requested a review from a team as a code owner March 20, 2025 09:37
@bwoebi
Avoid struct<Gneric = ()> in cbindgen-read definitions
a980579 
Works around mozilla/cbindgen#993 in cbindgen 0.27+

Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi requested review from a team as code owners March 20, 2025 10:03
@bwoebi bwoebi enabled auto-merge (squash) March 20, 2025 10:12
@pr-commenter
Copy link

pr-commenter bot commented Mar 20, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-03-20 13:40:37

Comparing candidate commit b8c6844 in PR branch bob/avoid-() with baseline commit e983996 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.078ms 6.096ms ± 0.013ms 6.094ms ± 0.003ms 6.098ms 6.104ms 6.162ms 6.209ms 1.89% 5.518 36.932 0.21% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.094ms; 6.098ms] or [-0.030%; +0.030%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 504.415µs 505.717µs ± 0.405µs 505.752µs ± 0.229µs 505.944µs 506.408µs 506.648µs 506.749µs 0.20% -0.343 0.784 0.08% 0.029µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1973361.808op/s 1977393.324op/s ± 1584.792op/s 1977253.891op/s ± 896.015op/s 1978248.335op/s 1980118.981op/s 1981839.642op/s 1982493.263op/s 0.26% 0.349 0.791 0.08% 112.062op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 452.588µs 453.501µs ± 0.344µs 453.454µs ± 0.209µs 453.686µs 454.064µs 454.480µs 454.660µs 0.27% 0.522 0.868 0.08% 0.024µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2199446.223op/s 2205068.817op/s ± 1672.849op/s 2205296.085op/s ± 1016.418op/s 2206060.440op/s 2207511.281op/s 2208797.965op/s 2209516.520op/s 0.19% -0.516 0.860 0.08% 118.288op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 175.536µs 176.736µs ± 0.326µs 176.791µs ± 0.191µs 176.946µs 177.193µs 177.301µs 177.419µs 0.36% -0.891 1.317 0.18% 0.023µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5636375.684op/s 5658165.590op/s ± 10469.261op/s 5656389.517op/s ± 6109.390op/s 5663491.888op/s 5678631.836op/s 5688914.017op/s 5696845.032op/s 0.72% 0.905 1.351 0.18% 740.289op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.503µs 37.617µs ± 0.046µs 37.614µs ± 0.027µs 37.640µs 37.701µs 37.749µs 37.765µs 0.40% 0.453 0.542 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26479691.308op/s 26584005.513op/s ± 32546.317op/s 26586059.383op/s ± 19394.116op/s 26605399.999op/s 26633878.092op/s 26658224.155op/s 26664380.558op/s 0.29% -0.445 0.532 0.12% 2301.372op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.213µs 48.320µs ± 0.051µs 48.308µs ± 0.023µs 48.338µs 48.411µs 48.463µs 48.611µs 0.63% 1.615 5.416 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20571485.210op/s 20695365.206op/s ± 21895.291op/s 20700315.186op/s ± 10045.454op/s 20708167.561op/s 20719454.097op/s 20737561.885op/s 20741396.504op/s 0.20% -1.600 5.328 0.11% 1548.231op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.660µs; 505.773µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1977173.687op/s; 1977612.961op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [453.453µs; 453.549µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2204836.976op/s; 2205300.658op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.691µs; 176.782µs] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5656714.651op/s; 5659616.528op/s] or [-0.026%; +0.026%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.610µs; 37.623µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26579494.907op/s; 26588516.120op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.313µs; 48.327µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20692330.729op/s; 20698399.683op/s] or [-0.015%; +0.015%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 148.652µs 149.412µs ± 0.407µs 149.343µs ± 0.153µs 149.521µs 149.847µs 150.555µs 153.273µs 2.63% 5.135 42.086 0.27% 0.029µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [149.355µs; 149.468µs] or [-0.038%; +0.038%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.368µs 2.420µs ± 0.017µs 2.417µs ± 0.008µs 2.426µs 2.454µs 2.474µs 2.478µs 2.50% 0.747 2.580 0.70% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.417µs; 2.422µs] or [-0.097%; +0.097%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.599µs 209.033µs ± 0.165µs 209.032µs ± 0.103µs 209.142µs 209.314µs 209.415µs 209.439µs 0.19% -0.112 0.137 0.08% 0.012µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4774659.292op/s 4783947.977op/s ± 3782.868op/s 4783962.245op/s ± 2367.733op/s 4786062.666op/s 4789963.431op/s 4793773.783op/s 4793879.813op/s 0.21% 0.117 0.139 0.08% 267.489op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.250µs 18.314µs ± 0.104µs 18.306µs ± 0.022µs 18.329µs 18.352µs 18.405µs 19.694µs 7.58% 11.835 153.826 0.57% 0.007µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 50776209.022op/s 54605217.380op/s ± 290886.593op/s 54626190.203op/s ± 66200.338op/s 54685657.145op/s 54775312.944op/s 54786337.578op/s 54793248.357op/s 0.31% -11.565 148.896 0.53% 20568.788op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.668µs 10.727µs ± 0.039µs 10.724µs ± 0.035µs 10.758µs 10.789µs 10.809µs 10.825µs 0.94% 0.355 -1.011 0.36% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 92376455.373op/s 93225388.851op/s ± 339187.117op/s 93247182.646op/s ± 302215.877op/s 93552370.617op/s 93663687.600op/s 93698851.690op/s 93734835.686op/s 0.52% -0.346 -1.024 0.36% 23984.151op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.010µs; 209.055µs] or [-0.011%; +0.011%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4783423.708op/s; 4784472.246op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.299µs; 18.328µs] or [-0.079%; +0.079%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [54564903.295op/s; 54645531.464op/s] or [-0.074%; +0.074%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.721µs; 10.732µs] or [-0.050%; +0.050%] None None None
normalization/normalize_name/normalize_name/good throughput [93178380.779op/s; 93272396.924op/s] or [-0.050%; +0.050%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 65.612µs 65.906µs ± 0.231µs 65.881µs ± 0.067µs 65.946µs 66.080µs 66.374µs 68.642µs 4.19% 8.696 97.464 0.35% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [65.874µs; 65.938µs] or [-0.049%; +0.049%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.202µs 3.177µs ± 1.427µs 2.982µs ± 0.024µs 3.006µs 3.652µs 13.856µs 14.909µs 399.96% 7.402 55.717 44.80% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.979µs; 3.375µs] or [-6.225%; +6.225%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 245.650ns 254.946ns ± 10.337ns 250.289ns ± 2.078ns 254.785ns 280.574ns 284.728ns 285.534ns 14.08% 1.685 1.500 4.04% 0.731ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [253.513ns; 256.378ns] or [-0.562%; +0.562%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 55.165ms 55.866ms ± 0.419ms 56.061ms ± 0.200ms 56.186ms 56.401ms 56.538ms 56.752ms 1.23% -0.381 -1.347 0.75% 0.030ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [55.808ms; 55.924ms] or [-0.104%; +0.104%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.260µs 33.202µs ± 1.209µs 32.474µs ± 0.147µs 34.739µs 35.372µs 35.439µs 36.019µs 10.92% 0.936 -1.009 3.63% 0.086µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.034µs; 33.370µs] or [-0.505%; +0.505%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.898µs 3.915µs ± 0.002µs 3.915µs ± 0.001µs 3.916µs 3.918µs 3.919µs 3.921µs 0.14% -2.390 13.574 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 255064986.665op/s 255438265.368op/s ± 156551.180op/s 255422632.491op/s ± 67839.993op/s 255485941.888op/s 255687791.178op/s 255879384.894op/s 256573245.888op/s 0.45% 2.408 13.729 0.06% 11069.840op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.675µs 82.125µs ± 0.236µs 82.116µs ± 0.173µs 82.251µs 82.529µs 82.814µs 82.900µs 0.95% 0.769 0.415 0.29% 0.017µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12062724.983op/s 12176690.560op/s ± 34986.121op/s 12177825.399op/s ± 25664.204op/s 12205768.757op/s 12219086.337op/s 12230360.948op/s 12243711.274op/s 0.54% -0.753 0.374 0.29% 2473.892op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.384µs 76.777µs ± 0.278µs 76.713µs ± 0.173µs 76.949µs 77.311µs 77.535µs 77.613µs 1.17% 0.922 0.186 0.36% 0.020µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12884363.428op/s 13024841.918op/s ± 46985.263op/s 13035620.988op/s ± 29525.774op/s 13063481.700op/s 13080295.777op/s 13088275.577op/s 13091714.254op/s 0.43% -0.908 0.151 0.36% 3322.360op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.914µs ± 0.003µs 3.915µs ± 0.001µs 3.916µs 3.918µs 3.920µs 3.921µs 0.15% -2.611 18.279 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255068028.960op/s 255462824.815op/s ± 179086.943op/s 255451064.715op/s ± 79562.542op/s 255531215.281op/s 255726731.817op/s 255909396.493op/s 256872392.554op/s 0.56% 2.639 18.544 0.07% 12663.359op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 71.872µs 72.339µs ± 0.357µs 72.288µs ± 0.254µs 72.528µs 73.096µs 73.306µs 73.586µs 1.80% 1.032 0.752 0.49% 0.025µs 1 200
credit_card/is_card_number/378282246310005 throughput 13589584.004op/s 13824195.468op/s ± 67798.432op/s 13833609.778op/s ± 48544.540op/s 13883121.595op/s 13899371.053op/s 13910969.262op/s 13913608.901op/s 0.58% -1.007 0.674 0.49% 4794.073op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.795µs 52.130µs ± 0.097µs 52.133µs ± 0.061µs 52.192µs 52.277µs 52.328µs 52.368µs 0.45% -0.389 0.331 0.19% 0.007µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19095579.642op/s 19182894.803op/s ± 35874.388op/s 19181574.182op/s ± 22510.528op/s 19204019.402op/s 19244962.984op/s 19278451.053op/s 19306964.444op/s 0.65% 0.401 0.350 0.19% 2536.702op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.431µs 6.446µs ± 0.020µs 6.443µs ± 0.003µs 6.446µs 6.455µs 6.536µs 6.633µs 2.96% 5.998 43.417 0.31% 0.001µs 1 200
credit_card/is_card_number/x371413321323331 throughput 150752944.463op/s 155134821.062op/s ± 473858.042op/s 155211777.626op/s ± 72217.947op/s 155280100.891op/s 155428759.516op/s 155483199.324op/s 155489214.826op/s 0.18% -5.912 42.109 0.30% 33506.824op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.894µs 3.915µs ± 0.003µs 3.915µs ± 0.001µs 3.916µs 3.919µs 3.922µs 3.931µs 0.40% -0.634 13.932 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254410867.078op/s 255428483.014op/s ± 202902.561op/s 255424279.475op/s ± 76602.014op/s 255499067.428op/s 255727815.139op/s 255901465.436op/s 256801960.258op/s 0.54% 0.671 14.044 0.08% 14347.378op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.047µs 64.261µs ± 0.092µs 64.254µs ± 0.046µs 64.297µs 64.435µs 64.569µs 64.703µs 0.70% 1.218 3.356 0.14% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15455264.539op/s 15561664.218op/s ± 22327.021op/s 15563300.958op/s ± 11167.126op/s 15575350.839op/s 15592784.129op/s 15608159.899op/s 15613615.072op/s 0.32% -1.202 3.295 0.14% 1578.759op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 58.168µs 58.310µs ± 0.120µs 58.282µs ± 0.030µs 58.317µs 58.508µs 58.923µs 59.093µs 1.39% 3.808 18.315 0.20% 0.008µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 16922591.345op/s 17149677.059op/s ± 34957.400op/s 17157912.499op/s ± 8771.706op/s 17165113.623op/s 17177433.772op/s 17189336.784op/s 17191485.057op/s 0.20% -3.773 18.003 0.20% 2471.861op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.896µs 3.915µs ± 0.003µs 3.915µs ± 0.001µs 3.917µs 3.920µs 3.923µs 3.937µs 0.56% 0.544 17.174 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 253983868.694op/s 255398555.125op/s ± 206226.108op/s 255397764.275op/s ± 79511.021op/s 255492066.978op/s 255594800.139op/s 255903109.841op/s 256668122.291op/s 0.50% -0.499 17.101 0.08% 14582.388op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.545µs 54.804µs ± 0.244µs 54.673µs ± 0.048µs 55.026µs 55.206µs 55.591µs 55.701µs 1.88% 1.328 0.979 0.44% 0.017µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17953104.725op/s 18247295.796op/s ± 80803.199op/s 18290694.609op/s ± 15956.205op/s 18300757.194op/s 18319323.335op/s 18326764.316op/s 18333645.907op/s 0.23% -1.312 0.904 0.44% 5713.649op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.790µs 52.125µs ± 0.120µs 52.132µs ± 0.080µs 52.209µs 52.278µs 52.415µs 52.494µs 0.69% -0.164 0.277 0.23% 0.009µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19049960.605op/s 19184664.990op/s ± 44294.010op/s 19182126.095op/s ± 29451.180op/s 19212789.957op/s 19262302.667op/s 19292133.312op/s 19308898.325op/s 0.66% 0.180 0.271 0.23% 3132.060op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.431µs 6.451µs ± 0.029µs 6.442µs ± 0.003µs 6.446µs 6.513µs 6.567µs 6.635µs 3.00% 3.847 16.939 0.44% 0.002µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 150714613.388op/s 155023284.155op/s ± 674449.227op/s 155236492.755op/s ± 65471.815op/s 155290969.830op/s 155371722.701op/s 155467732.612op/s 155491690.156op/s 0.16% -3.793 16.408 0.43% 47690.762op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.915µs; 3.915µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ throughput [255416568.880op/s; 255459961.856op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.092µs; 82.158µs] or [-0.040%; +0.040%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12171841.820op/s; 12181539.300op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [76.739µs; 76.816µs] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13018330.212op/s; 13031353.623op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.915µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255438005.087op/s; 255487644.543op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.289µs; 72.388µs] or [-0.068%; +0.068%] None None None
credit_card/is_card_number/378282246310005 throughput [13814799.257op/s; 13833591.679op/s] or [-0.068%; +0.068%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.116µs; 52.143µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19177922.958op/s; 19187866.648op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.443µs; 6.449µs] or [-0.043%; +0.043%] None None None
credit_card/is_card_number/x371413321323331 throughput [155069148.894op/s; 155200493.229op/s] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.915µs; 3.915µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [255400362.671op/s; 255456603.358op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.248µs; 64.273µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15558569.908op/s; 15564758.529op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [58.294µs; 58.327µs] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17144832.300op/s; 17154521.819op/s] or [-0.028%; +0.028%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.915µs; 3.916µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255369974.170op/s; 255427136.080op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.770µs; 54.838µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18236097.250op/s; 18258494.343op/s] or [-0.061%; +0.061%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.109µs; 52.142µs] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19178526.266op/s; 19190803.714op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.447µs; 6.455µs] or [-0.061%; +0.061%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [154929811.978op/s; 155116756.331op/s] or [-0.060%; +0.060%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.919µs 5.009µs ± 0.052µs 5.007µs ± 0.050µs 5.047µs 5.106µs 5.111µs 5.111µs 2.09% 0.240 -1.079 1.05% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.002µs; 5.016µs] or [-0.145%; +0.145%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b8c6844 1742477333 bob/avoid-()
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.251µs 25.492µs ± 10.728µs 17.845µs ± 0.419µs 35.407µs 45.379µs 46.238µs 71.113µs 298.51% 1.171 1.180 41.98% 0.759µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.005µs; 26.978µs] or [-5.832%; +5.832%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.87%. Comparing base (e983996) to head (b8c6844).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
- Coverage   72.90%   72.87%   -0.03%     
==========================================
  Files         334      334              
  Lines       50995    50995              
==========================================
- Hits        37177    37165      -12     
- Misses      13818    13830      +12
Components Coverage Δ
crashtracker 42.85% <ø> (+0.02%) ⬆️
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.96% <ø> (ø)
data-pipeline-ffi 90.29% <ø> (ø)
ddcommon 81.37% <ø> (ø)
ddcommon-ffi 66.10% <ø> (ø)
ddtelemetry 61.87% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.60% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.41% <ø> (ø)
profiling 81.76% <ø> (-0.10%) ⬇️
profiling-ffi 70.65% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 42.07% <0.00%> (ø)
sidecar-ffi 9.85% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 91.59% <ø> (ø)
trace-mini-agent 74.66% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 96.00% <ø> (ø)
trace-protobuf 78.13% <ø> (ø)
trace-utils 92.87% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r1viollet
Copy link
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.80 MB 7.80 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 24.54 MB 24.54 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 78.39 MB 78.39 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.73 MB 7.73 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 72.72 MB 72.72 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 23.13 MB 23.13 MB 0% (0 B) 👌
i686-alpine-linux-musl
Artifact Baseline Commit Change
/i686-alpine-linux-musl/lib/libdatadog_profiling.a 67.67 MB 67.67 MB 0% (0 B) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so 8.25 MB 8.25 MB 0% (0 B) 👌
/i686-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.70 MB 23.70 MB 0% (0 B) 👌
i686-unknown-linux-gnu
Artifact Baseline Commit Change
/i686-unknown-linux-gnu/lib/libdatadog_profiling.a 68.55 MB 68.55 MB 0% (0 B) 👌
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so 8.13 MB 8.13 MB 0% (0 B) 👌
/i686-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 21.31 MB 21.31 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 17.17 MB 17.17 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 54.81 KB 54.81 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 118.45 MB 118.45 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 707.80 MB 707.80 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.05 MB 5.05 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 54.81 KB 54.81 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 16.28 MB 16.28 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.95 MB 26.95 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.57 MB 14.57 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 55.66 KB 55.66 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 120.51 MB 120.50 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 699.47 MB 699.47 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.84 MB 3.84 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 55.66 KB 55.66 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.95 MB 16.95 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.94 MB 24.94 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 67.67 MB 67.67 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.25 MB 8.25 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.70 MB 23.70 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 68.55 MB 68.55 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.13 MB 8.13 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 21.31 MB 21.31 MB 0% (0 B) 👌

@bwoebi bwoebi merged commit f95c346 into main Mar 20, 2025
31 checks passed
@bwoebi bwoebi deleted the bob/avoid-() branch March 20, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullegranddc paullegranddc paullegranddc approved these changes

Assignees
No one assigned
Labels
sidecar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bwoebi @codecov-commenter @r1viollet @paullegranddc @ivoanjo