Do not pass stdin to login shell in self_test #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `stdin` is `/dev/tty` -- such as when `nix-installer.sh` is piped into `sh` -- and one of the root user's login shell configuration files includes `mesg n` (as it does in Ubuntu 24.04), then running `bash -l` will modify the write permissions of `/dev/tty`. Closes DeterminateSystems#1412.
|
Thanks for the merge 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
stdinis/dev/tty-- such as whennix-installer.shis piped intosh-- and one of the root user's login shell configuration files includesmesg n(as it does in Ubuntu 24.04), then runningbash -lwill modify the write permissions of/dev/tty.Closes #1412.
Checklist
cargo fmtnix buildnix flake check(except hydraJobs because they freeze up my laptop)Validating with
install.determinate.systemsIf a maintainer has added the
upload to s3label to this PR, it will become available for installation viainstall.determinate.systems: