Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProvisionDeterminateNixd: cleanup /etc/nix and /etc/nix/nix.conf #1417

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Feb 7, 2025

determinate-nixd fully manages /etc/nix/nix.conf, so it's safe to remove that file unconditionally. If there are no other files in /etc/nix, then we'll also remove that directory; otherwise, we leave it alone.

If we don't clean this up, it prevents uninstall-reinstalls from working.

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

determinate-nixd fully manages /etc/nix/nix.conf, so it's safe to remove
that file unconditionally. If there are no other files in /etc/nix, then
we'll also remove that directory; otherwise, we leave it alone.

If we don't clean this up, it prevents uninstall-reinstalls from
working.
@cole-h cole-h enabled auto-merge (squash) February 7, 2025 18:55
@cole-h cole-h merged commit 5f70d1d into main Feb 7, 2025
22 checks passed
@cole-h cole-h deleted the determinate-cleanup-etc-nix.conf branch February 7, 2025 19:11
@cole-h cole-h added this to the 0.36.0 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants