Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select快速mount和unmount的时候，react-resize报错 #814

Closed
zjy01 opened this issue Jul 2, 2018 · 3 comments
Closed

Select快速mount和unmount的时候，react-resize报错 #814

zjy01 opened this issue Jul 2, 2018 · 3 comments

Comments

@zjy01
Copy link

zjy01 commented Jul 2, 2018 •
edited
Loading

Description

界面默认展示Select，但是由于逻辑，快熟取消Select的展示，这时候，就会出现报错，整个页面奔溃

image

Reproduce Steps

  1. a = true 的时候，render 一个 Select
  2. 在mount做一个异步操作，设置 a = false

Error Trace (if possible)

image
@iplus26 iplus26 mentioned this issue Jul 4, 2018
Closed
ingver added a commit to ingver/element-react that referenced this issue Jul 26, 2018
@ingver
fix bug ElemeFE#814
2d956d8 
Fixes ElemeFE#814.

`addResizeListener` was called in `componentDidUdpate`. Now it's called in `componentDidMount`.
@ingver ingver mentioned this issue Jul 26, 2018
Merged
4 tasks
e1emeb0t pushed a commit that referenced this issue Jul 27, 2018
@ingver @e1emeb0t
fix bug #814
aacec99 
Fixes #814.

`addResizeListener` was called in `componentDidUdpate`. Now it's called in `componentDidMount`.
@mytharcher
Copy link
Contributor

mytharcher commented Aug 15, 2018 •
edited
Loading

我看这个 PR 已经合并了，但是还未发布新的版本，请问什么时候可以发布呢？

@fhvknb
Copy link

fhvknb commented Aug 17, 2018

It must happend when i reload page where Select component .

@fhvknb
Copy link

fhvknb commented Aug 17, 2018

thanks @zjy01 . I got it.

@mytharcher mytharcher mentioned this issue Oct 5, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mytharcher @zjy01 @fhvknb