Rails 6 compatibility #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests fail with
NoMethodError:
undefined method `trigger_transactional_callbacks?' for #<AfterCommitEverywhere::Wrap:0x00007f97c9012f08>
# ./spec/after_commit_everywhere_spec.rb:303:in `block (4 levels) in <top (required)>'
joevandyk
changed the title
|
It looks like failing test is related to Lazy transactions feature. See how developers of the Isolator gem worked around it: https://github.com/palkan/isolator/pull/20/files#diff-85a7e76d12511ed333927e4fd2b8da1d |
|
I will merge your PR and fix Travis builds after few hours. You did all the job for me, thank you! |
|
Thanks! Any chance you could release a new gem version? |
|
Already released, sorry for the delay! Please grab v0.1.4 from Rubygems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.