remove unnecessary fencing interfering with delayed_off #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump @EverythingSmartHome I guess this fix would make other ep lite owners happier too. Really wondering why nobody was complaining yet. |
|
Sorry for the delay, had some time to test tonight. Looks good to me, thanks! |
EverythingSmartHome
merged commit ec8f5e8
into
EverythingSmartHome:main
30 checks passed
|
So that's what happened... Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the check for the state returns true as long as the delayed_off time has not passed it will not trigger a publish_state that will reset the delay time. This results in the occupancy turning off after the delay_time has passed and immediately turns back on in the next cycle as the publish_state is not fenced anymore.
To fix this I simply removed the check for the state before the state is published as esphome already has deduplication built in for binary sensors (see binary_sensor.cpp#L15)