chore: refactor ld2450 lambda #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverythingSmartHome
merged commit 15d544a
into
EverythingSmartHome:main
30 checks passed
|
Awesome, thank you! I had to add a commit to merge a previous PR which I think was done correctly, please let me know if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to debug why I was getting values in Home Assistant sticking and refactored the code to remove as many calls to read values from the sensors that were already available.
It turns out that the sensor sometimes sends final values that are in the appropriate ranges which causes the symptom (thesensor is on the latest firmware).
I thought I'd offer the changes up for consideration as it may help with optimisation.