fix for MID-4189 #57
Merged
fix for MID-4189 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Jason. I have formally merged the pull request. But the master branch has moved to Spring Boot, which means that the old XML configuration files are now obsolete. The LDAP and CAS auth should be moved to annotations and profiles. We are currently working on migrating LDAP confguration to annotations. But I'm not sure about CAS. However, when LDAP is done it may be used as an inspiration to migrate CAS configuration as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all that is need to fix MID-4189, I had some older changes that were affecting the other comments I made for L45-48.