[$125] Android - Expense - Total amount is cut off in the expense report

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Money Requests

Action Performed:

Precondition:

• Device font size is minimum.

1. Launch ND or hybrid app.
2. Go to workspace chat.
3. Submit an expense in foreign currency.
4. Tap on the expense preview.

Expected Result:

Total amount will not appear cut off in the expense report.

Actual Result:

Total amount is cut off in the expense report.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6767291_1741690370708.Screen_Recording_20250311_185004_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021899755205225937253
• Upwork Job ID: 1899755205225937253
• Last Price Increase: 2025-03-19

Issue Owner

Current Issue Owner: @thesahindia

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-11 12:57:15 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Expense - Total amount is cut off in the expense report

What is the root cause of that problem?

Here

App/src/components/ReportActionItem/MoneyReportView.tsx

Lines 195 to 199 in 75ab857

	<Text
	numberOfLines={1}
	style={[styles.taskTitleMenuItem, styles.alignSelfCenter, !isTotalUpdated && styles.offlineFeedback.pending]}
	>
	{formattedTotalAmount}

We're not wrapping Text element like we did for total
here

App/src/components/ReportActionItem/MoneyReportView.tsx

Lines 171 to 176 in 75ab857

	<View style={[styles.flex1, styles.justifyContentCenter]}>
	<Text
	style={[styles.textLabelSupporting]}
	numberOfLines={1}
	>
	{translate('common.total')}

What changes do you think we should make in order to solve the problem?

we should wrap out text in view and add the same styles we apply on total text [styles.flex1, styles.alignItemsEnd]

<View style={[styles.flex1, styles.alignItemsEnd]}>
    <Text
        numberOfLines={1}
        style={[styles.taskTitleMenuItem, styles.alignSelfCenter, !isTotalUpdated && styles.offlineFeedback.pending]}
    >
        {formattedTotalAmount}
    </Text>
</View>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @samranahm Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[cristipaval]

Demoting: it is a visual minor thing happening in rare cases: Device font size has to be minimum.

[Themoonalsofall]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Expense - Total amount is cut off in the expense report

What is the root cause of that problem?

We are styling the amount with fontSizeXLarge, which will cause a UI break when the device font size is set to the minimum.

App/src/styles/variables.ts

Line 61 in 75ab857

fontSizeXLarge: 22,

What changes do you think we should make in order to solve the problem?

We should use the getValueUsingPixelRatio function to update the font size when the user changes the device font size.

We can create a new fontSize style or can use fontSizeNormalHeight. This will be decided by the design team.

        taskTitleMenuItem: {
            ...writingDirection.ltr,
            ...headlineFont,
            fontSize: variables.fontSizeNormalHeight,
            lineHeight: variables.lineHeightSizeh2,
            maxWidth: '100%',
            ...wordBreak.breakWord,
        },

Note: We should also update all other amount displays to be consistent.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[kadiealexander]

Android <> iOS bug swap

[jliexpensify]

@cristipaval do you think this is worth fixing, or is it too much of an edge-case?

[jliexpensify]

@danieldoglas Sorry, I didn't realise you were assigned - is this worth fixing, or is it an edge-case? Since it's Android and the font has to be at a minimum?

[cristipaval]

@cristipaval do you think this is worth fixing, or is it too much of an edge-case?

Before closing, I would lower the price for it and see if there are takers 🤷‍♂

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021899755205225937253

[dukenv0307]

@jliexpensify I can help take it as C+ since I'm on low bandwidth

[jliexpensify]

Done, all yours @dukenv0307

[dukenv0307]

@Themoonalsofall's proposal looks good. IMO, the fontSizeXLarge should be getValueUsingPixelRatio(22, 28). What do you think @Expensify/design?

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @danieldoglas is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[shawnborton]

IMO, the fontSizeXLarge should be getValueUsingPixelRatio(22, 28). What do you think @Expensify/design?

What makes you say that out of curiosity? Does that currently not have the scaling value?

[Themoonalsofall]

Does that currently not have the scaling value?

@shawnborton The main problem of this issue is we are setting the font size to 22 with no scaling

App/src/styles/variables.ts

Line 61 in 75ab857

fontSizeXLarge: 22,

App/src/styles/index.ts

Lines 4267 to 4274 in 75ab857

	taskTitleMenuItem: {
	...writingDirection.ltr,
	...headlineFont,
	fontSize: variables.fontSizeXLarge,
	lineHeight: variables.lineHeightSizeh2,
	maxWidth: '100%',
	...wordBreak.breakWord,
	},

[shawnborton]

Got it, but is that needed to fix the original bug from the report?

[Themoonalsofall]

@shawnborton yes, we should use getValueUsingPixelRatio to set the font size of the total value

[melvin-bot]

@danieldoglas, @jliexpensify, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jliexpensify]

Waiting on @danieldoglas to assign a Contributor.

[melvin-bot]

@danieldoglas @jliexpensify @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[dukenv0307]

@shawnborton @danieldoglas Do you agree with #58205 (comment)?

[shawnborton]

Well, I'm not sure if my question was answered. Do we need to adjust anything with the font size to fix the fact that it is getting cut off? Perhaps the container that wraps the font is too small or something and is cutting it off? Basically, I would love to be consistent here and keep the font size the same as elsewhere (since it's reusing an h2 style). @Themoonalsofall didn't really answer my question... do we need to add that style to actually fix the problem?

[Themoonalsofall]

@shawnborton We are setting fontSize to 22 with lineHeight to lineHeightSizeh2

App/src/styles/variables.ts

Line 115 in 75ab857

lineHeightSizeh2: getValueUsingPixelRatio(24, 28),

The problem here is that the total amount has too large font size with small line height. We can fix this bug by increasing the line height or decreasing the fontSize.

and i think we can reduce the font size to make everything looks more balanced

[shawnborton]

I don't think we need to do any of that personally. We don't want to reduce our font sizes.

@dukenv0307 can we please evaluate other proposals? Thanks!

[dukenv0307]

@shawnborton @jliexpensify Seem like the issue is fixed somewhere. I can't reproduce anymore

[Themoonalsofall]

I can't reproduce it now, look like this PR fixed it

[jliexpensify]

Thanks @dukenv0307 and @Themoonalsofall - lets close this then!

[shawnborton]

That's great news!