This repository was archived by the owner on Sep 29, 2021. It is now read-only.
unique -> uniqueWithRetry Fixes #27 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemliu
reviewed
Oct 7, 2019
| @@ -132,13 +132,12 @@ export function getCodeFromEvent(event: AllFdEvents, options?: Options): string | |||
|
|
|||
| export function getCode(suite: string, description: string, events: AllFdEvents[], options?: Options) { | |||
| let firstVisitUrl = ''; | |||
| for (let i = 0; i < events.length; ++i) { | |||
| const event = events[i]; | |||
| for (const event of events) { | |||
There was a problem hiding this comment.
Wow! I can't believe I wrote that piece of code. Thanks for doing the code-review as well 😌
|
@willemliu thank you, could you also create a new release for the chrome plugin store thing, so I can kick my custom version to the curb? |
|
@burner absolutely. I'm going to do some smoke-testing and after that I'll bundle a new release for Chrome. |
|
@willemliu perfect thank you |
willemliufdmg
pushed a commit
that referenced
this pull request
Oct 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uniqueWithRetry tries to get an HTML element by ID to make tests less brittle.
unique fails if IDs are invalid HTML, which can still be displayed by browsers.
also makes typescript and the linter happier.