Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When Drag & Drop more gems than 1 on tool, entire stack is removed instead of one piece from stack #110

Closed
DexterSK opened this issue Nov 20, 2023 · 4 comments · Fixed by #112
Closed

When Drag & Drop more gems than 1 on tool, entire stack is removed instead of one piece from stack #110

DexterSK opened this issue Nov 20, 2023 · 4 comments · Fixed by #112
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@DexterSK
Copy link

DexterSK commented Nov 20, 2023 •
edited
Loading

Describe the bug
When Drag & Drop more gems than 1 on tool, entire stack is removed instead of one piece from stack.
Didn't looked at the code but this probably can be easily fixed with something like this

if( item.getAmount() > 1 )
    item.setAmount( item.getAmount() - 1 );
else
    player.getInventory().removeItem( item );

To Reproduce (Important)
Steps to reproduce the behavior:

  1. Give eg. 64x Telepathy Gem
  2. Put stack of gems to tool
  3. All 64 pieces will be removed instead of one piece from stack

Expected behavior
Remove only one item from itemstack

Screenshots
If applicable, add screenshots to help explain your problem.

Server Log
doesn't matter

Environment (REQUIRED)

  • Server Software and Version (Spigot/Paper): Paper
  • Minecraft version: git-Purpur-2083 (MC: 1.20.2)*
  • Slimefun version: DEV - 1104 (git c977454e)
  • FNAmplification version: DEV - 93 (git 7bc0110)
@FN-FAL113 FN-FAL113 added bug Something isn't working good first issue Good for newcomers labels Nov 21, 2023
@FN-FAL113
Copy link
Owner

Will be fixed on next update

FN-FAL113 added a commit that referenced this issue Nov 24, 2023
@FN-FAL113
bug fixes and telepathy suggestion added
3b73dd7 
## Changes
- resolves #111 and #110
- fix throwable torch "cannot drop air", possibly the item might be despawned before executing #dropItemNaturally.
- add telepathy support for hoes and shovels

## To do
- Use blob-builds updater when its available from sf through pom dependency version upgrade.
@FN-FAL113 FN-FAL113 mentioned this issue Nov 24, 2023
Merged
4 tasks
@FN-FAL113
Copy link
Owner

FN-FAL113 commented Dec 8, 2023 •
edited
Loading

Fixed on build 95, please download latest build from https://blob.build which has the new auto updater

@DexterSK
Copy link
Author

Fixed on build 95, please download latest build from https://blob.build which has the new auto updater

Please fix tier 2 etc too, seems like you have fixed only tier 1 gems. thanks

@FN-FAL113
Copy link
Owner

Fixed on build 95, please download latest build from https://blob.build which has the new auto updater

Please fix tier 2 etc too, seems like you have fixed only tier 1 gems. thanks

Next update, forgot they are different implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug fixes and telepathy suggestion added FN-FAL113/FN-FAL-s-Amplifications
2 participants
@DexterSK @FN-FAL113