-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java Assignment3 upload by HyunsooJung #21
base: main
Are you sure you want to change the base?
Changes from 6 commits
7c1cac0
e99be9a
b4110f8
c4d5d74
8335a7a
8c81625
82a9719
b532bf1
9b83298
0fce5ad
fbec7c0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package me.day05.practice; | ||
|
||
import java.util.List; | ||
|
||
public class ArrayUtil { | ||
|
||
static <T> T[] listToArray(List<T> list) { | ||
T[] resultArray = (T[]) new Object[list.size()]; | ||
|
||
for (int i = 0; i < resultArray.length; i++) | ||
resultArray[i] = list.get(i); | ||
|
||
return resultArray; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
package me.day05.practice; | ||
|
||
import java.time.LocalDate; | ||
import java.time.format.DateTimeFormatter; | ||
import java.util.Arrays; | ||
import java.util.Objects; | ||
|
||
public class Electronic { | ||
|
||
enum CompanyName { SAMSUNG, LG, APPLE } | ||
enum AuthMethod { FINGERPRINT, PIN, PATTERN, FACE } | ||
|
||
private static final int MAX_REGISTRATION_NUMBER = 9999; | ||
|
||
private static int registrationNo; | ||
|
||
private String productNo; | ||
private String modelName; | ||
private CompanyName companyName; | ||
private String dateOfMade; | ||
private AuthMethod[] authMethod; | ||
|
||
Electronic () { | ||
registrationNo++; | ||
setDateOfMade(); | ||
setProductNo(); | ||
} | ||
|
||
Electronic (String modelName, CompanyName companyName, AuthMethod[] authMethod) { | ||
this(); | ||
this.modelName = modelName; | ||
this.companyName = companyName; | ||
this.authMethod = authMethod; | ||
} | ||
|
||
private void setDateOfMade(){ | ||
DateTimeFormatter timeFormatter = DateTimeFormatter.ofPattern("yyMMdd"); | ||
dateOfMade = timeFormatter.format(LocalDate.now()); | ||
} | ||
|
||
private void setProductNo(){ | ||
if (registrationNo >= MAX_REGISTRATION_NUMBER) resetRegistrationNo(); | ||
productNo = dateOfMade + String.format("%4d", registrationNo).replace(" ", "0"); | ||
} | ||
|
||
private void resetRegistrationNo(){ | ||
registrationNo = 1; | ||
} | ||
|
||
public boolean isContainAuthMethod(AuthMethod authMethod){ | ||
for (AuthMethod auth : this.authMethod) | ||
if (authMethod.equals(auth)) return true; | ||
return false; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 부분은 요구사항에는 없었지만 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 굳굳!! 꼭 단어나 문법이 정확하진 않아도 되지만 가급적이면 지켜주는게 좋아요. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 헉! 지금까지 계속 contain으로 사용하고 있었네요 맙소사,, 감사합니다 |
||
|
||
public String getProductNo() { | ||
return productNo; | ||
} | ||
|
||
public String getModelName() { | ||
return modelName; | ||
} | ||
|
||
public void setModelName(String modelName) { | ||
this.modelName = modelName; | ||
} | ||
|
||
public CompanyName getCompanyName() { | ||
return companyName; | ||
} | ||
|
||
public void setCompanyName(CompanyName companyName) { | ||
this.companyName = companyName; | ||
} | ||
|
||
public String getDateOfMade() { | ||
return dateOfMade; | ||
} | ||
|
||
public AuthMethod[] getAuthMethod() { | ||
return authMethod; | ||
} | ||
|
||
public void setAuthMethod(AuthMethod[] authMethod) { | ||
this.authMethod = authMethod; | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return Objects.hash(productNo, modelName, companyName, dateOfMade, Arrays.hashCode(authMethod)); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 꼭 모든 프로퍼티가 아니라 특정 몇개의 프로퍼티로 hashCode를 만들기도 하죠. 좋은 아이디어네요. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 부분은 한번 찾아보고, 고민해 보겠습니다 |
||
|
||
@Override | ||
public boolean equals(Object obj) { | ||
if (this == obj) return true; | ||
if (obj == null || getClass() != obj.getClass()) return false; | ||
return Objects.equals(productNo, ((Electronic)obj).productNo); | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return "Electronic { " + | ||
"productNo=" + productNo + | ||
", modelName=" + modelName + | ||
", companyName= " + companyName + | ||
", dateOfMade=" + dateOfMade + | ||
", authMethod=" + Arrays.toString(authMethod) + " }"; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package me.day05.practice; | ||
|
||
import java.util.List; | ||
|
||
public class ElectronicArrayUtil { | ||
|
||
static Electronic[] listToArray(List<Electronic> list) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 메서드가 분리된 유틸 클래스에 있는 것과 Electronic에 있는 것, 어떤 차이가 있을까요? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Users 에서도 groupBy 기능이 생길 것 같아서 제네릭으로 해당 유틸 로직을 만드는 데 실패해서 임시방편으로 Electronic 클래스를 위한 유틸클래스로 분리했습니다 |
||
Electronic[] resultArray = new Electronic[list.size()]; | ||
|
||
for (int i = 0; i < resultArray.length; i++) | ||
resultArray[i] = list.get(i); | ||
|
||
return resultArray; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,140 @@ | ||
package me.day05.practice; | ||
|
||
import me.day05.practice.Electronic.AuthMethod; | ||
import me.day05.practice.Electronic.CompanyName; | ||
|
||
import java.util.*; | ||
|
||
public class Electronics { | ||
|
||
private static final int DEFAULT_CAPACITY = 10; // Default initial capacity | ||
private static final Electronic[] EMPTY_ELECTRONIC_LIST = {}; | ||
|
||
private static Electronic[] electronicList; | ||
private static Electronics electronicsInstance; | ||
|
||
private int size; | ||
private int capacity; | ||
|
||
Electronics(){ | ||
electronicList = EMPTY_ELECTRONIC_LIST; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 싱글톤으로 사용하고자 한다면 생성자는 private으로 막아주는 것이 일반적입니다. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 헉 너무 기본적인 실수,, 열번 백번 더 확인하겠습니다,,! |
||
|
||
// TODO: 1. Electronics 클래스의 객체를 싱글톤으로 생성하는 함수를 작성하시오. | ||
public static Electronics getInstance() { | ||
if (electronicsInstance == null) electronicsInstance = new Electronics(); | ||
return electronicsInstance; | ||
} | ||
|
||
// TODO: 2. 전자제품 일련번호 productNo를 통해 인자로 주어진 일련번호에 해당하는 전자제품을 반환하는 함수를 작성하시오. | ||
public Optional<Electronic> findByProductNo(String productNo){ | ||
for (Electronic electronic : electronicList) | ||
if (productNo.equals(electronic.getProductNo())) | ||
return Optional.of(electronic); | ||
|
||
return Optional.empty(); | ||
} | ||
Comment on lines
+29
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
다시 생각해보니 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이정도면 충분할 것 같습니다. (사실 해도 됩니다. null 체크야 해서 나쁠건 없지만, 지금 코드가 보편적이긴 합니다.) |
||
|
||
// TODO: 3. 전자제품들 중 인자로 주어진 제조 회사를 찾아서 하나의 배열에 반환하는 함수를 작성하시오. | ||
public Optional<Electronic[]> groupByCompanyName(CompanyName company){ | ||
|
||
List<Electronic> temp = new ArrayList<>(); | ||
|
||
for (Electronic electronic : electronicList) | ||
// 테스트용 임시 조건 ( electronic != null ) | ||
if (electronic != null && electronic.getCompanyName().equals(company)) | ||
temp.add(electronic); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 부분은 |
||
|
||
Electronic[] companyNameGroup = | ||
temp.isEmpty() ? null : ElectronicArrayUtil.listToArray(temp); | ||
|
||
return Optional.ofNullable(companyNameGroup); | ||
} | ||
|
||
public Optional<Electronic> findByCompanyName(CompanyName company){ | ||
for (Electronic electronic : electronicList) | ||
if (company.equals(electronic.getCompanyName())) | ||
return Optional.of(electronic); | ||
|
||
return Optional.empty(); | ||
} | ||
|
||
// TODO: 4. 전자제품들 중 인자로 주어진 인증 방법을 찾아서 하나의 배열에 반환하는 함수를 작성하시오. | ||
public Optional<Electronic[]> groupByAuthMethod(AuthMethod authMethod){ | ||
|
||
List<Electronic> temp = new ArrayList<>(); | ||
|
||
for (Electronic electronic : electronicList) | ||
// 테스트용 임시 조건 ( electronic != null ) | ||
if (electronic != null && electronic.isContainAuthMethod(authMethod)) | ||
temp.add(electronic); | ||
|
||
Electronic[] authMethodNameGroup = | ||
temp.isEmpty() ? null : ElectronicArrayUtil.listToArray(temp); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이부분을 제네릭을 사용한 유틸 클래스(ArrayUtil)의 사용으로 따라서 임시방편으로 Electronic 클래스를 위한 유틸 클래스로 대체했습니다. 여기서 의문이 생겼습니다. 새로운 유틸 클래스를 만드는 방법? 저는 개인적으로 최선책은 유틸 클래스에 선언, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 저라면 Electronics에 선언했을 것 같습니다. 일단 넘어갑시다 ㅎㅎ 하 이렇게 하면 또 궁금하셔서 잠 못 주무실테니 키워드는 'static 객체지향' 이런 쪽으로 검색해보세요 |
||
|
||
return Optional.ofNullable(authMethodNameGroup); | ||
} | ||
|
||
public int getSize() { | ||
return size; | ||
} | ||
|
||
public void setSize(int size) { | ||
this.size = size; | ||
} | ||
|
||
public int getCapacity() { | ||
return capacity; | ||
} | ||
|
||
public void setCapacity(int capacity) { | ||
this.capacity = capacity; | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return Objects.hash(Arrays.hashCode(electronicList), size, capacity); | ||
} | ||
|
||
@Override | ||
public boolean equals(Object obj) { | ||
if (this == obj) return true; | ||
if (obj == null || getClass() != obj.getClass()) return false; | ||
return Objects.equals(hashCode(), ((Electronics)obj).hashCode()); | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return "Users { " + | ||
"size=" + size + | ||
", capacity=" + capacity + | ||
", electronicList= " + Arrays.toString(electronicList) + " }"; | ||
} | ||
|
||
//==================================== TEST CODE ====================================// | ||
public void add (Electronic electronic) { | ||
if (electronicList == EMPTY_ELECTRONIC_LIST) | ||
electronicList = new Electronic[DEFAULT_CAPACITY]; | ||
/* 배열 크기 체크하고 늘리는 로직 구현 할 것 */ | ||
electronicList[size++] = electronic; | ||
} | ||
|
||
public static void main(String[] args) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 오잉? 이건 지우는게 좋을 것 같아요. Electronics class에서 하시면 안될 것 같아요! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ㅎㅎ,, 이번 과제는 구현과제라서 저 혼자 테스트 해보고 다음부턴 지우거나 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 좋습니다! |
||
Electronic iPhone13 = new Electronic("아이폰13", CompanyName.APPLE, new AuthMethod[]{AuthMethod.FACE, AuthMethod.PIN, AuthMethod.PATTERN}); | ||
Electronic iPhone12 = new Electronic("아이폰12", CompanyName.APPLE, new AuthMethod[]{AuthMethod.FACE, AuthMethod.PIN, AuthMethod.PATTERN}); | ||
Electronic galaxyS22 = new Electronic("갤럭시S22", CompanyName.SAMSUNG, new AuthMethod[]{AuthMethod.FINGERPRINT, AuthMethod.PIN, AuthMethod.PATTERN}); | ||
|
||
Electronics electronics = getInstance(); | ||
electronics.add(iPhone13); | ||
electronics.add(iPhone12); | ||
electronics.add(galaxyS22); | ||
|
||
// System.out.println(electronics); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 의미 없는 코드는 제거해주세요. |
||
|
||
Optional<Electronic[]> authMethodGroupPIN = electronics.groupByAuthMethod(AuthMethod.FACE); | ||
authMethodGroupPIN.ifPresent(value -> System.out.println(Arrays.toString(value))); | ||
|
||
Optional<Electronic[]> companyNameGroupAPPLE = electronics.groupByCompanyName(CompanyName.SAMSUNG); | ||
companyNameGroupAPPLE.ifPresent(value -> System.out.println(Arrays.toString(value))); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 메서드는 사용되는 코드인가요?
사용되지 않는 코드는 지워주세요.