[1차 VER1.0] Java ToyProject upload by TaeIlKIM #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seonghye0n
reviewed
May 10, 2023
|
|
||
| private Customers() {}; | ||
|
|
||
| public void refresh() { |
There was a problem hiding this comment.
refresh 메서드를 오버로딩해서 한 고객에 대해서만 업데이트하는 메서드가 있으면 좋을 것 같습니다!
고객 한 명을 추가했는데 모든 고객을 refresh한다면 비효율적이니까요 😀
seonghye0n
reviewed
May 10, 2023
| return customerArrs; | ||
| } | ||
|
|
||
| public Comparator<Customer> sortName(int num) { |
There was a problem hiding this comment.
람다식으로 할 생각은 전혀 못했었는데 덕분에 하나 배워갑니다!👍
seonghye0n
reviewed
May 11, 2023
| try { | ||
| System.out.println("Input Customer's Spent Time: "); | ||
| Integer time = Integer.parseInt(nextLine(Message.END_MSG)); | ||
| if (time < 0) throw new InputRangeException(); |
There was a problem hiding this comment.
setter에 해당 조건이 들어가면 더 좋을 것 같다는 생각이 듭니다!
다른데서 해당 조건 없이 setter를 쓴다면 결국 잘못된 값이 입력이 되지 않을까요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코드리뷰 부탁드립니다.
긴 코드 인데 읽어주셔서 너무 감사합니다! 🙏
TODO - Refactoring