[1차 VER1.0...] Java ToyProject upload by WooSeokLee #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
빡센리뷰 부탁드리겠습니다ㅠ
많이 부족함을 느꼈고 일단 최대한 기능이 잘돌아가게끔하는 것을 우선순위로 두고 만들었기에 코드가 많이 지저분합니다. 시간나는대로 리팩토링및 예외처리 추가등을 통해 계속 커밋을 통해 수정할 예정입니다.
피드백해주신대로 커밋컨벤션을 지키긴했으나, 정신없이 진행해서그런지 커밋단위가 들쭉날쭉하네요 @.@