-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new config option convertAllTo … #23
base: main
Are you sure you want to change the base?
Conversation
…o another format - can close issue FatehAK#20
Hey @netolicak, thanks for the PR! Sorry I couldn't get back earlier. Could you please check the above lint issues? Also, I tried running your changes on my local, and they seem to be failing at: bundler[filePath + "." + format].source = content;
^
TypeError: Cannot set properties of undefined (setting 'source') Since we are generating a new file and not altering an existing one, we should write a new file using fs at the same path as the existing file, I believe. Also, here are a few suggestions for your PR:
|
This is an important feature. Is there something else in the vite plugin ecosystem that can make up for this feature in the meantime? @FatehAK |
A quick search gave me this @Lastofthefirst https://www.npmjs.com/package/vite-imagetools |
hi @FatehAK , is this request is going to be merged? thanks. |
for converting all image files to another format - can close issue #20
What is the purpose of this pull request?
Description
Added new config option convertAllTo for converting all image files to another format - can close issue #20
Checks
fixes #number
pnpm lint && pnpm build
Additional Context