Add 'manual' type to named reporting intervals #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason for doing this is to simplify unit testing, but also interactive testing with reporters. Rather than having repeating output, or (in unit tests) having to wait for some time before output is generated, a report batch can now be triggered on demand.
|
Some tests would be highly appreciated. The change looks good though. |
|
BTW, the build failure in one of the Travis builds is the reason why I'm testing out wercker. |
|
Yes, tests will come. In fact, this is what I'm working towards. Ironically, the reporters that exist in exometer_core (lager & tty) are quite hard to test. I've done most of my experimentation with the statsd reporter, which is much easier to rig for testing. I knew I should have moved it to exometer_core along with the rest! |
uwiger
added a commit
that referenced
this pull request
Apr 4, 2015
Add 'manual' type to named reporting intervals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for doing this is to simplify unit testing, but also
interactive testing with reporters. Rather than having repeating output,
or (in unit tests) having to wait for some time before output is generated,
a report batch can now be triggered on demand.