Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add switch to control in guardian timeout before killing firebird server process #7468

Closed
AlexPeshkoff opened this issue Feb 2, 2023 · 1 comment
Closed

Add switch to control in guardian timeout before killing firebird server process #7468

AlexPeshkoff opened this issue Feb 2, 2023 · 1 comment
Assignees
@AlexPeshkoff
Labels
fix-version: 3.0.11 fix-version: 4.0.3 fix-version: 5.0 Beta 1 type: improvement

Comments

@AlexPeshkoff
Copy link
Member

Currently FB guardian waits for 3 seconds after notifying server that it's time to shutdown and kills it. That's bad strategy for big cache - server has not enough time to flash it to the disk. Timeout value should be set by guardian's switch, default should be increased.
@AlexPeshkoff AlexPeshkoff self-assigned this Feb 2, 2023
AlexPeshkoff added a commit that referenced this issue Feb 7, 2023
@AlexPeshkoff
Implemented #7468: Add switch to control in guardian timeout before k…
71a27ce 
…illing firebird server process
AlexPeshkoff added a commit that referenced this issue Feb 8, 2023
@AlexPeshkoff
Backported #7468: Add switch to control in guardian timeout before ki…
96aad0d 
…lling firebird server process
AlexPeshkoff added a commit that referenced this issue Feb 8, 2023
@AlexPeshkoff
Backported #7468: Add switch to control in guardian timeout before ki…
9ce968c 
…lling firebird server process

(cherry picked from commit 96aad0d)
@AlexPeshkoff
Copy link
Member Author

In FB 3 & 4 default timeout is left 3 seconds, increased to 30 - only in FB5 and higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexPeshkoff AlexPeshkoff

Labels
fix-version: 3.0.11 fix-version: 4.0.3 fix-version: 5.0 Beta 1 type: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexPeshkoff