-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3049 Use poco based parsers #3073
Conversation
src/Hl7.Fhir.Base/Serialization/engine/FhirSerializationEngineFactory.Legacy.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed it for snafus, added come helpful comments for reviewer (I hope). No formal PR review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. One comment: will this not hugely interfere with andrzejs PR?
Actually, no, because I did the renames in a separate project! So I am pulling this and will update his PR with develop6 afterwards. |
FIxes #3049.
This PR:
The idea is that old code keeps compiling, but will start using the newer POCO code.
The biggest change is that the newer parsers are strict by default, so some unit tests (and FhirClient and DirectorySource) had to be changes to switch back to RECOVERABLE/OSTRICH.