Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enable poll even when realTime flag is enabled #149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajinkyasurya
Copy link
Contributor

  • Real time service for on-prem solution is currently unstable and development is still in-progress.
  • Requesting to enable poll even when useRealtime flag is enabled as failure to update environment is undesirable.
  • I understand that I can externally pollEnvironment but I wanted to raise a PR and get an official review to save back and forth.

@rolodato rolodato changed the title refactor: enable poll even when realTime flag is enabled feat!: enable poll even when realTime flag is enabled Feb 24, 2025
@rolodato
Copy link
Member

This would be a breaking change, since it changes the behaviour for NewClient in a way that requires a code change to preserve the old behaviour. I've updated the PR's title to reflect that.

I agree that it makes sense to have this as a default, since not all changes to the environment document such as editing segments will cause a real-time update. I'll defer to @gagantrivedi for a decision on this.

@gagantrivedi
Copy link
Member

gagantrivedi commented Mar 6, 2025

since not all changes to the environment document such as editing segments will cause a real-time update

I don't think that's true? ref: https://github.com/Flagsmith/flagsmith/blob/main/api/environments/tasks.py#L26
If we really want to support this, we will have to add another config option, something like WithRealtimeAndSSE.

@rolodato
Copy link
Member

rolodato commented Mar 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants