-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better y-axis titles when showing multiple sensors #1346
Conversation
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
…as peak or capacity prices in EUR/kW Signed-off-by: F.N. Claessen <[email protected]>
* docs: add doctest example for price unit Signed-off-by: F.N. Claessen <[email protected]> * docs: changelog entry Signed-off-by: F.N. Claessen <[email protected]> * feat(ci): run all doctests in the utils subpackage Signed-off-by: F.N. Claessen <[email protected]> * dev: skip other tests (for testing the new feat) Signed-off-by: F.N. Claessen <[email protected]> * fix: fix all failing doctests Signed-off-by: F.N. Claessen <[email protected]> * Revert "dev: skip other tests (for testing the new feat)" This reverts commit 5bedeca. * docs: changelog entry Signed-off-by: F.N. Claessen <[email protected]> * refactor: shorter doctest Signed-off-by: F.N. Claessen <[email protected]> * feat: add doctests for data/schemas to ci Signed-off-by: F.N. Claessen <[email protected]> * fix: doctest syntax Signed-off-by: F.N. Claessen <[email protected]> * fix: do not repeat running normal tests Signed-off-by: F.N. Claessen <[email protected]> --------- Signed-off-by: F.N. Claessen <[email protected]>
@BelhsanHmida This is the important bit to check. The rest is of this PR comes from me merging #1347 into this PR branch, sorry. |
I looked into the relevant refactoring, and it looks good! I tested it, and the results are as expected. I also tested the code overall, and it works fine. However, I found cases where shared units don’t work properly (e.g., wind speed in km/h and m/h). I’m guessing these units aren’t implemented yet, but I just wanted to note this. Here are the test results for a couple of units: Screencast from 2025-03-05 01-51-43.webm |
Another feature I wanted to ask about is handling sensors with the same dimension but different units—for example, one in MW and another in kW. Currently when we overlay these sensors, the Y-axis shows Value (a.u.). Should we consider standardizing the Y-axis to the smallest unit (e.g., kW in this case) for better clarity. so it would be |
High-quality review, thank you!!
Good finds. For now I'll
I don't think we should unless we also scale the MW data to kW. I'll open a new issue for this, because it would be a good feature imo. #1352 |
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
…ts/shared-base-units # Conflicts: # documentation/changelog.rst
Description
documentation/changelog.rst
Look & Feel
Before:
After (notice the y-axis title changed from
Value
toTemperature
):How to test
The docstrings of the new unit util functions include doctests. Doctests aren't part of the automated test suite, though, but they will be - #1347