-
Notifications
You must be signed in to change notification settings - Fork 0
Apply application's theme to MarkdownEditor component #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flang
wants to merge
2
commits into
master
Choose a base branch
from
issue-10
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
src/main/resources/META-INF/resources/frontend/connector.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /*- | ||
| * #%L | ||
| * Markdown Editor Add-on | ||
| * %% | ||
| * Copyright (C) 2024 Flowing Code | ||
| * %% | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * #L% | ||
| */ | ||
| (function() { | ||
|
|
||
| window.Vaadin.Flow.fcMarkdownEditorConnector = { | ||
| observeThemeChange: markDownEditor => { | ||
| // Check whether the connector was already initialized for markDownEditor | ||
| if (markDownEditor.$connector) { | ||
| return; | ||
| } | ||
|
|
||
| markDownEditor.$connector = {}; | ||
|
|
||
| const supportedTheme = theme => ['light', 'dark'].includes(theme); | ||
|
|
||
| const setDataColorMode = theme => { | ||
| if (supportedTheme(theme)) { | ||
| markDownEditor.setAttribute('data-color-mode', theme); | ||
| } else { | ||
| markDownEditor.removeAttribute('data-color-mode'); | ||
| } | ||
| }; | ||
|
|
||
| // Get theme from html element when using Vaadin's @Theme annotation | ||
| const mainTheme = document.documentElement.getAttribute('theme'); | ||
| if (supportedTheme(mainTheme)) { | ||
| setDataColorMode(mainTheme); | ||
| } else { | ||
| // Listen for theme changes in body element otherwise | ||
|
|
||
| // options for the observer (which mutations to observe) | ||
| const config = { attributes: true }; | ||
|
|
||
| // callback function to execute when mutations are observed | ||
| const callback = (mutationList, observer) => { | ||
| for (const mutation of mutationList) { | ||
| if (mutation.type === 'attributes' && mutation.attributeName === 'theme') { | ||
| const themeName = mutation.target.getAttribute(mutation.attributeName); | ||
| setDataColorMode(themeName); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| // create an observer instance linked to the callback function | ||
| markDownEditor.$connector.themeChangeObserver = new MutationObserver(callback); | ||
|
|
||
| // start observing html tag for configured mutations | ||
| markDownEditor.$connector.themeChangeObserver.observe(document.documentElement, config); | ||
|
|
||
| // start observing body tag for configured mutations | ||
| markDownEditor.$connector.themeChangeObserver.observe(document.body, config); | ||
| } | ||
| }, | ||
| unobserveThemeChange: markDownEditor => { | ||
| // stop observing the target node for configured mutations | ||
| if (markDownEditor.$connector.themeChangeObserver) { | ||
| markDownEditor.$connector.themeChangeObserver.disconnect(); | ||
| markDownEditor.$connector.themeChangeObserver = null; | ||
| } | ||
| } | ||
| } | ||
| })(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Guard against missing connector on first paint
ui.getPage().executeJs("window.Vaadin.Flow.fcMarkdownEditorConnector.observeThemeChange($0)", …)will throw a client-side error if the connector script has not yet been executed (e.g., if the bundle is still downloading).Consider adding a defensive check:
or wrap the call in the JS connector itself.