Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVX2 acceleration is only compiling with MSVC build system #71

Closed
RedNicStone opened this issue Oct 14, 2021 · 1 comment
Closed

AVX2 acceleration is only compiling with MSVC build system #71

RedNicStone opened this issue Oct 14, 2021 · 1 comment

Comments

@RedNicStone
Copy link

RedNicStone commented Oct 14, 2021

When just using the main header file morton.h the preprocessor directives disallow compilation of AVX2 accelerated functions when using any compiler other than MSVC. See these lines:

#if defined(__BMI2__) || (defined(__AVX2__) && defined(_MSC_VER))
#include "morton_BMI.h"
#elif defined(__AVX512BITALG__)
#include "morton_AVX512BITALG.h"
#endif

I don't see any apparent reason for this but the effect is that building is prevented on most compiler systems.
I would appreciate removal of this requirement if it isn't there on purpose as my current solution is a duplicated morton.h without the directives which is neither beautiful nor a good solution.

Thanks for your support!

@RedNicStone RedNicStone changed the title AVX2 is only compiling with MSVC build system AVX2 acceleration is only compiling with MSVC build system Oct 14, 2021
@Forceflow
Copy link
Owner

Good call, will fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants