Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with round trip between m3D_e_for(...) and m3D_d_for(..) #81

Closed
norlesh opened this issue Apr 1, 2023 · 1 comment
Closed
Assignees
Labels

Comments

@norlesh
Copy link

norlesh commented Apr 1, 2023

While studying your implementation using the simple for loop in the file morton3D.h I noticed that on line 129 of m3D_e_for the loop is implemented as
for (unsigned int i = 0; i < checkbits; ++i) {

while the corresponding m#D_e_for on line 253 is implemented as
for (unsigned int i = 0; i <= checkbits; ++i) {

while I haven't run your code I can confirm that when doing a port of the functions into a C# project I needed to change both loops to use i < checkbits before I could get my round trip tests to pass.

Forceflow added a commit that referenced this issue May 24, 2023
@Forceflow
Copy link
Owner

Changed this, all correctness tests still run. Intuitively, this tracks.

@Forceflow Forceflow self-assigned this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants