This repository was archived by the owner on Feb 19, 2022. It is now read-only.
Reduce overhead accessing process.env in benchmark #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing
process.env.NODE_ENV
is quite expensive. (See raxjs/server-side-rendering-comparison#5)The overhead can be reduced by replacing
process.env
to equivalent plain JS objects. (Ideal solution would be to use minified build...)Before the patch:
After the patch:
Benchmark is run on Node v7.6.0.