Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check delta when swiping in progress #74

Closed
mctep opened this issue Jun 2, 2017 · 2 comments
Closed

Do not check delta when swiping in progress #74

mctep opened this issue Jun 2, 2017 · 2 comments

Comments

@mctep
Copy link

mctep commented Jun 2, 2017

Hello!! Thank you for awesome lib! It is great.

But I have suggestion to improve some case. I want to make swipe to delete like in gmail mobile app.

<Swipeable
  onSwiped={this.handleSwiped}
  onSwipingLeft={this.handleSwipingLeft}
  onSwipingRight={this.handleSwipingRight}
/>

before

As you can see after I move finger back to the start point there is some lag when I change swiping direction.

In my case it can be fixed with changes in this line:

if (pos.absX < delta && pos.absY < delta && !this.swipeable.swiping) return;
@hartzis
Copy link
Collaborator

hartzis commented Jun 4, 2017

hey @mctep,

Thanks for the great issue write up and example gif!

seems reasonable, would you like to make a PR with a simple test case added for it? If not i should be able to get around to it within the next couple of weeks.

Should be able to be a minor version bump too i think.

Cheers!

mctep pushed a commit to mctep/react-swipeable that referenced this issue Jun 5, 2017
mctep pushed a commit to mctep/react-swipeable that referenced this issue Jun 5, 2017
hartzis added a commit that referenced this issue Jun 6, 2017
Do not check delta when swiping in progress #74
@hartzis
Copy link
Collaborator

hartzis commented Jun 7, 2017

closed by v4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants