setup single touchmove event listener #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartzis
commented
Mar 14, 2019
| @@ -47,12 +47,52 @@ function rotateXYByAngle(pos, angle) { | |||
| } | |||
|
|
|||
| const getTouchHandlerOption = props => { | |||
| if (props.touchHandlerOption) return props.touchHandlerOption | |||
| if (typeof props.touchHandlerOption !== 'undefined') | |||
There was a problem hiding this comment.
Bug Fix: should allow for false for touchHandlerOption prop. Specifically when options and passive aren't supported by the browser being used.
5 tasks
hartzis
commented
Mar 14, 2019
| <input style={{margin: "0px"}} | ||
| type="checkbox" | ||
| checked={showComponent} | ||
| onChange={(e)=>this.updateValue('showComponent', e.target.checked)}/> |
There was a problem hiding this comment.
add the showHook and the showComponent options in the examples to verify the cleanUp functionality
|
closing in favor of #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Setup single
touchmovelistener and setup thetouchmovebefore any swiping starts.alternate solution for #127. other possible solution is #129
touchmoveevent listener and set it up before any swiping starts<Swipeable />anduseSwipeableAdditional fixes:
falsewhentouchHandlerOptionprop is notundefinedfalsewhen an options object is not supportedTasks: