Skip to content
This repository was archived by the owner on Mar 16, 2021. It is now read-only.

Weaken Parameter type for clearBut Methods #89

Conversation

jannisveerkamp
Copy link
Contributor

clearBut() methods should only need an instance of AbstractTrayPreference instead the concrete implementation TrayPreference.

Since we are only weakening the type of the parameter it should not break anything.

This is needed in case you're using an alternative Implementation.

@passsy

@codecov-io
Copy link

Codecov Report

Merging #89 into master will not impact coverage.

@@           Coverage Diff            @@
##             master    #89    +/-   ##
========================================
  Coverage       100%   100%            
- Complexity        0    271   +271     
========================================
  Files            22     22            
  Lines           659    659            
  Branches         98     57    -41     
========================================
  Hits            659    659
Impacted Files Coverage Δ Complexity Δ
...rary/src/main/java/net/grandcentrix/tray/Tray.java 100% <ø> (ø) 8 <ø> (+8)
...grandcentrix/tray/provider/TrayProviderHelper.java 100% <100%> (ø) 21 <ø> (+21)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192b10d...caccae5. Read the comment docs.

@passsy passsy merged commit 347a97f into master Feb 7, 2017
@passsy passsy deleted the bugfix/clear_but_uses_abstract_class_instead_of_implementation branch February 7, 2017 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants