Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO C++11 requires at least one argument for the "..." in a variadic macro #297

Closed
juan-lunarg opened this issue Nov 17, 2022 · 2 comments
Closed

ISO C++11 requires at least one argument for the "..." in a variadic macro #297

juan-lunarg opened this issue Nov 17, 2022 · 2 comments
Labels
compatibility Compatibility with some platforms next release To be done as soon as possible

Comments

@juan-lunarg
Copy link
Contributor

If you compile a project with -Wpedantic and -Werror you get this problem.

[build] /home/juan/projects/layers/layers/vk_mem_alloc.h:14549:69: error: ISO C++11 requires at least one argument for the "..." in a variadic macro [-Werror]
[build] 14549 |                     VMA_DEBUG_LOG("    Allocated as DedicatedMemory");
[build]       |                                                                     ^
[build] /home/juan/projects/layers/layers/vk_mem_alloc.h:14590:65: error: ISO C++11 requires at least one argument for the "..." in a variadic macro [-Werror]
[build] 14590 |                 VMA_DEBUG_LOG("    Allocated as DedicatedMemory");
[build]       |                                                                 ^
[build] /home/juan/projects/layers/layers/vk_mem_alloc.h:14595:52: error: ISO C++11 requires at least one argument for the "..." in a variadic macro [-Werror]
[build] 14595 |         VMA_DEBUG_LOG("    vkAllocateMemory FAILED");
[build]       |                                                    ^
[build] /home/juan/projects/layers/layers/vk_mem_alloc.h:14763:52: error: ISO C++11 requires at least one argument for the "..." in a variadic macro [-Werror]
[build] 14763 |         VMA_DEBUG_LOG("    vkAllocateMemory FAILED");
@juan-lunarg juan-lunarg mentioned this issue Nov 17, 2022
Merged
@adam-sawicki-a adam-sawicki-a added next release To be done as soon as possible compatibility Compatibility with some platforms labels Nov 22, 2022
adam-sawicki-a added a commit that referenced this issue Nov 29, 2022
@adam-sawicki-a
Split macros into separate VMA_DEBUG_LOG and VMA_DEBUG_LOG_FORMAT
6d2fe13 
To fix compiler errors with -Wpedantic -Werror - see #297
@adam-sawicki-a
Copy link
Contributor

Thank you for reporting this issue. I pushed some changes. Please check if they fix the problem on your platform.

@juan-lunarg
Copy link
Contributor Author

Thank you for reporting this issue. I pushed some changes. Please check if they fix the problem on your platform.

Just checked and the issue has been fixed, thank you 👍

@mjrister mjrister mentioned this issue May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility Compatibility with some platforms next release To be done as soon as possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adam-sawicki-a @juan-lunarg