Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Webpack v5 #523

Merged
merged 12 commits into from
Apr 16, 2023
Merged

Upgrade to Webpack v5 #523

merged 12 commits into from
Apr 16, 2023

Conversation

faultyserver
Copy link
Member

Contributing to the Donation Tracker

First of all, thank you for taking the time to contribute!

Please fill out the template below and check the following boxes:

  • I've added tests or modified existing tests for the change.
  • I've humanly end-to-end tested the change by running an instance of the tracker.

Description of the Change

Gets us further out of 2019 and into the modern era by upgrading from webpack v4 to the latest v5. Most of this work is directly following the migration guide here: https://webpack.js.org/migrate/5/.

The entire process involved a number of disparate changes, which will be notated by inline comments below.

Verification Process

Confirmed both development and production builds produced working bundles with no errors. Also confirmed that development hot reloading works.

version: 1.0.30001006
resolution: "caniuse-lite@npm:1.0.30001006"
checksum: ca3283309c3a6b8cf4eb26fec3ed1040b9a4f65bc5dca0b9ee6c35482d440072e7bc537a693294bffd605b5fe10ddfd7d36d96ca72802bdf9b94c093e91a54df
"caniuse-lite@npm:^1.0.0, caniuse-lite@npm:^1.0.30000989, caniuse-lite@npm:^1.0.30001004, caniuse-lite@npm:^1.0.30001006, caniuse-lite@npm:^1.0.30001449, caniuse-lite@npm:^1.0.30001464":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was updated via yarn dlx browserslist --update-db, which just updates this package dependency to have the new caniuse information, stop complaining about being out of date, and reducing our bundle size as new features are available natively.

@faultyserver faultyserver marked this pull request as ready for review April 8, 2023 03:06
Copy link
Member Author

@faultyserver faultyserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round two, this time fixing the test environment

uraniumanchor
uraniumanchor previously approved these changes Apr 16, 2023
@faultyserver faultyserver merged commit 42d1b0b into master Apr 16, 2023
@faultyserver faultyserver deleted the deps/webpack branch April 16, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants