Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] 5.2.3 #30

Merged
merged 106 commits into from
Jul 18, 2021
Merged

[DONE] 5.2.3 #30

merged 106 commits into from
Jul 18, 2021

Conversation

xhyrom
Copy link
Member

@xhyrom xhyrom commented Jul 6, 2021 •
edited
Loading

Features

  • Cleanup
  • Better jsdoc for docs
  • Command classes
  • Cooldown bypass for app owner/team
  • Cooldown fix
  • Typings for command classes
  • Event classes
  • Typings for event classes
  • Workflows (auto checks for PRs)
  • Min node version in package.json
  • GPayload
  • GPayload typings
  • Sending only attachments in message
  • Sending only embeds in message
  • Back Structures with djs v13
  • Removed guild.prefix/language (use getCommandPrefix(), getLanguage())
  • Added .setDisabled() to MessageSelectMenu
  • Support ws(raw) events
  • client.events -> client.gevents
  • interaction.think() in slash cmd
  • interaction.createdTimestamp
  • GInteraction typings
  • GInteraction jsdoc
  • GInteraction
  • GPayload test
  • Normal arguments
  • expectedArgs => args
  • SlashCommand.STRING => ArgumentType.STRING
  • GEvents to @gcommands/events
  • Case sensitive commands
  • Embed attachments fix
  • Major fixes
  • Final Testing

Website

  • Guide gcommands.js.org/guide
  • Docs gcommands.js.org/docs
  • gcommands.js.org => gcommands.js.org/docs(Auto redirect to docs)

Status

  • These changes have been tested and formatted properly.
  • This PR introduces some Breaking changes.

@xhyrom xhyrom requested review from nexpid, iZboxo and SebestikCZ July 6, 2021 17:12
SebestikCZ
SebestikCZ approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@SebestikCZ SebestikCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine

@xhyrom xhyrom changed the title 4.4.0 [WIP] 4.4.0 Jul 6, 2021
@xhyrom xhyrom marked this pull request as draft July 6, 2021 17:58
@xhyrom xhyrom marked this pull request as draft July 16, 2021 09:20
@xhyrom xhyrom marked this pull request as ready for review July 17, 2021 17:36
@iZboxo
Copy link
Member

iZboxo commented Jul 17, 2021

I think everything is corect.

iZboxo
iZboxo approved these changes Jul 17, 2021
View reviewed changes
Copy link
Member

@iZboxo iZboxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is correct. Gcommands is best.

@xhyrom xhyrom changed the title [WIP] 5.2.3 [DONE] 5.2.3 Jul 18, 2021
@xhyrom xhyrom merged commit e668b71 into main Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hernikplays hernikplays hernikplays approved these changes

@nexpid nexpid nexpid approved these changes

@iZboxo iZboxo iZboxo approved these changes

@WurstMod WurstMod WurstMod approved these changes

@SebestikCZ SebestikCZ Awaiting requested review from SebestikCZ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xhyrom @iZboxo @hernikplays @SebestikCZ @nexpid @WurstMod