Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-370] Provide FileAttachment Theme #5670

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

JcMinarro
Copy link
Member

🎯 Goal

Create a new Theme FileAttachmentTheme used to customize FileAttachments.
This theme could have different values for sent messages from the current user and for sent messages for other users.

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@JcMinarro JcMinarro requested a review from a team as a code owner March 7, 2025 20:19
Copy link
Contributor

github-actions bot commented Mar 7, 2025

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.17 MB 3.17 MB 0.00 MB 🟢
stream-chat-android-offline 3.38 MB 3.38 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.87 MB 7.87 MB 0.00 MB 🟢
stream-chat-android-compose 9.86 MB 9.87 MB 0.00 MB 🟢

Copy link
Contributor

@VelikovPetar VelikovPetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one small remark, but otherwise looks good!

@JcMinarro JcMinarro force-pushed the feature/file-attachment-theme branch from 845d0e2 to 6778f90 Compare March 12, 2025 22:59
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants