[AND-332] Chat adaptive layout #5671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size Comparison 📏
|
…elFactory so that they can be used for save and restore state
…ng between list content modes
…he MessageListHeader
- DefaultThreePaneNavigator to ThreePaneDestination
- Decouple InfoContentMode to the ChatScreen
andremion
force-pushed
the
AND-332-adaptive-layout
branch
from
d83b5e9 to
78598bc
Compare
andremion
commented
Mar 10, 2025
| @@ -308,7 +308,7 @@ internal fun DefaultMessageListHeaderSubtitle( | |||
| internal fun DefaultMessageListHeaderTrailingContent( | |||
| channel: Channel, | |||
| currentUser: User?, | |||
| onClick: () -> Unit, | |||
| onClick: (() -> Unit)?, | |||
There was a problem hiding this comment.
Do not show any ripple effect when there is no click handler
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This is a second task of the experimental
ChatsScreenintroduced on #5556.It now has a better navigation API to support navigation on phones and tablets, with better configuration changes handling.
It also supports navigation from push notifications and pinned messages where a message is focused on opening.
Note
A future task will make the pinned messages to be listed inside the adaptive layout too.
🛠 Implementation details
ChatScreensupports a three-pane adaptive layout:ListContentMode.Panes are arranged on screen based on the device size:
30%of the screen width and Detail occupies70%.An optional Info pane can be displayed occupying half of the space of the Detail pane with a slide in/out transition.Enable adaptive layout in the Advanced options of the sample app
🎨 UI Changes
channels_nav_phone.webm
channels_nav_tablet.webm
screen_rotation_phone.webm
screen_rotation_tablet.webm
threads_phone.webm
threads_tablet.webm
nav_from_pinned_phone.webm
nav_from_pinned_tablet.webm
nav_from_push_phone.webm
nav_from_push_tablet.webm
🧪 Testing
Explain how this change can be tested (or why it can't be tested)
Provide a patch below if it is necessary for testing
Provide the patch summary here
🎉 GIF