-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHAT-790] support filter by custom data in search endpoint #264
Conversation
introduce channel.search sync typescript type definitions
@@ -128,6 +128,28 @@ export class Channel { | |||
}); | |||
} | |||
|
|||
async search(query, options = {}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some doc and examples of what query looks like?
...options, | ||
}; | ||
if (typeof query === 'string') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some doc for this search function as well!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
# Conflicts: # test/channels.js
fix: fix location renderer in localcommunity
Submit a pull request
CLA
Description of the pull request